Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transparent_background and other options for catppuccin/nvim #259

Open
reinux opened this issue Jun 30, 2024 · 2 comments
Open

transparent_background and other options for catppuccin/nvim #259

reinux opened this issue Jun 30, 2024 · 2 comments
Labels
help wanted Extra attention is needed

Comments

@reinux
Copy link

reinux commented Jun 30, 2024

There's a slew of options for catppuccin/nvim that might be worth being able to set.

On the other hand, the other apps catppuccin configures don't seem to have so many options made available, so I'm not sure if we want to expose all of them through catpppuccin/nix. (Cava does have a transparency option.)

I did make a fork with the transparent_background option, but I don't want to make a PR just yet, because this is my first time writing options for any nix packages, and I'm not confident regarding style and conventions etc. (e.g. do we keep the snake case?)

Any guidance would be appreciated!

@getchoo
Copy link
Member

getchoo commented Jul 2, 2024

a freeform module would probably be ideal here as we wouldn't need to constantly update our options to reflect the upstream port

PRs are welcome here

@toodeluna
Copy link

I made a pull request for this that adds a new option extraConfig which gets dynamically converted to a Lua table. It does use the type attrs instead of a freeform module which (as far as I can see) makes it easier to create the plugin settings dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants