Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from shipping dotfiles #29

Closed
sgoudham opened this issue Nov 27, 2024 · 5 comments · Fixed by #31
Closed

Move away from shipping dotfiles #29

sgoudham opened this issue Nov 27, 2024 · 5 comments · Fixed by #31
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sgoudham
Copy link

sgoudham commented Nov 27, 2024

Catppuccin, from an organisational point of view, has moved away from offering ports which are extremely customised and riced to the point where they are effectively someone's dotfiles.

The rofi port is possibly the best example of this across the organisation where it's simply 2 people's dotfiles (who are no longer involved/contributing to the organisation)

This port needs to be overhauled to provide a starting point for customisation with Catppuccin colours as the default, following the defaults of Rofi as much as possible. I don't use Rofi so I won't be the one taking on this work but happy to provide advice and guidance if someone is interested in overhauling this port and potentially becoming the future maintainer!

Feel free to reply to this issue or join our official discord if you'd like to chat more.

@sgoudham sgoudham added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 27, 2024
@sgoudham sgoudham pinned this issue Nov 27, 2024
@0xmayro
Copy link
Contributor

0xmayro commented Dec 14, 2024

Hello, I would like to help with the overhaul.
I have a question though:
should it be like waybar port providing the variables and letting the user decide how to use colors in the app?
or like the sway/i3 port setting the color ourselves in the app?

@isabelincorp
Copy link
Member

isabelincorp commented Dec 21, 2024

...should it be like waybar port providing the variables and letting the user decide how to use colors in the app? or like the sway/i3 port setting the color ourselves in the app?

Hello!
As a Rofi user, I believe it's better to have it defined like Waybar since theming here is very subjective. Some folks prefer accents everywhere, while some don't, so I think it's better to provide a framework like that from which people can jump to create their rice.

I can very much argue for this, considering I use my own custom-made Rofi rice because I honestly don't like the one provided. This port should only provide a copy-and-paste solution for people to put into their .rasi file.

The previews should only be just that—a preview of something a user can produce by plugging this theme into another commonly used Rofi theme.

edit: I saw the discord thread just now, but I'll keep this here for anyone else curious enough to check!

@kjnsn
Copy link

kjnsn commented Dec 21, 2024

I strongly suggest dumping the default rasi files, and applying the catppuccin colors to them: https://github.com/davatorium/rofi/wiki/Themes

This achieves both goals:

  1. Being just a color theme, no more, no less
  2. Providing a starting point for further customisation if desired

I'm confused by the desire to look for a "commonly used Rofi theme" when a default already exists. I also question the direction to encourage people to create their own rice, when dumping a rasi file somewhere is much, much lower effort.

@0xmayro
Copy link
Contributor

0xmayro commented Dec 21, 2024

I think we'll provide the overriden default as an option/example.
While still providing (maybe emphasizing?) the palette files

@sgoudham
Copy link
Author

sgoudham commented Dec 21, 2024

Let me define the (minimum) acceptance criteria for the PR to be raised:

  1. A rofi.tera file that generates *.rasi files via whiskers into the themes/ folder, this should just include the Catppuccin palette colours in a copy/paste-able format.
  2. An example default.rasi file dumped from Wiki: Themes (davatorium/rofi) with the injected Catppuccin colours defaulting to one flavour, this can be a separate file or if it's short enough, just in the README.md itself.
  3. The preview images are updated with the look/feel of the default configuration file, with Catppuccin applied of course.

I think it makes sense to have 1. and 2. but I'm following my assumption that the default configuration file is different to having the colours in a copy/paste-able format. Let me know if this is incorrect.

If there's enough interest, we can enable GitHub discussions for people to showcase their opinionated configurations or link to their dotfiles. Similar to ctp/nvim, ctp/tmux, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants