-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ModuleVersionDetails should have nativeBackends #129
Comments
I don't think I can do this before the deadline you set for a wednesday release. What's the specific reason you need this feature? I'd think that knowing there is an implementation (native or not) would be sufficient? |
Ah wait you linked another issue. |
I want to automatically add |
But couldn't you , for now, use the fact that a query for JVM + JS only returns one or the other for native modules? |
Well sure I guess in principle I could do it with two queries, but that would make something that is already too slow now twice as slow. |
Well I mean that if somebody is putting in an import statement we have to retrieve the artifacts anyway, right? So the moment you retrieve them you can check which ones you got. That shouldn't involve any queries AFAICT. |
No, because as-per the resolution to #128, it only sends me the artifacts I asked for. It doesn't tell me that the module also has other artifacts available. |
But that's what I mean, you'd normally ask for both artifacts, right?
THat should be enough information, right? (*) well, it also depends on which backends you have enabled in the IDE I guess. |
No, I don't, because I want to get a filtered list of modules. Instead I ask for only the modules that are compatible with at least one of the enabled backends. |
@quintesse Note that I can have a |
Reassigning to 1.3 because I think I can live without this for now. |
Yes, that was the second bullet point I mentioned above.
I'm not sure I understand. If you ask for the list of modules that are compatible with either JVM or JS then you have your answer right there, don't you? Some of the modules will have JVM artifacts, some JS and some both. It would seem to me that's enough information? |
The
ModuleVersionDetails
class should have an attribute that tells me what are the supportedBackends
.@quintesse would you please take a look at this. Thanks.
The text was updated successfully, but these errors were encountered: