Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceylon maven improvements #131

Open
vietj opened this issue Nov 2, 2015 · 7 comments
Open

Ceylon maven improvements #131

vietj opened this issue Nov 2, 2015 · 7 comments
Milestone

Comments

@vietj
Copy link

vietj commented Nov 2, 2015

there are a few issues with this code:

  • it jarjar Arquillian / Aether code that can create classloading conflict issues
  • it uses Arquillian facade and it could use directly Aether
  • the Aether version is very old
@quintesse
Copy link
Member

With "this code" I assume you refer to the maven-support JAR?

@quintesse quintesse added this to the 1.3 milestone Nov 2, 2015
@quintesse
Copy link
Member

The issue also doesn't make very clear what the proposed improvements are, I assume:

  • get rid of Arquillian by using Aether directly
  • update to a newer version of Aether in the process

Right?

But I'm not sure what the problem is with the class loader? And that problem would not be fixed by using Aether directly? So what would you propose to do about it?

@alesj
Copy link
Member

alesj commented Nov 2, 2015

it uses Arquillian facade and it could use directly Aether

Aether API must be one of the worst to work with, hence I chose the lesser evil -- ShrinkWarp over Aether. But feel free to change it.

@vietj
Copy link
Author

vietj commented Nov 2, 2015

@quintesse yes both : one stone two birds
@alesj it may be horrible but once the code is written it's done

@vietj
Copy link
Author

vietj commented Nov 2, 2015

I won't change it myself :), it's an issue for improvement.

@vietj
Copy link
Author

vietj commented Nov 2, 2015

I mean it's not that I don't want to do it, it's just an issue to record what needs to be done.

@vietj
Copy link
Author

vietj commented Nov 2, 2015

the main problem is that the ceylon-maven-plugin cannot resolve maven module because the aether api is too old and conflicting with the recent maven aether apis creating classloading prb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants