Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gum confirm no longer lets you disable negative message #559

Open
txotxopue opened this issue May 2, 2024 · 2 comments
Open

gum confirm no longer lets you disable negative message #559

txotxopue opened this issue May 2, 2024 · 2 comments
Labels
bug Something isn't working cmd/confirm
Milestone

Comments

@txotxopue
Copy link

Describe the bug
Prior to v0.14.0 you could execute:
gum confirm --affirmative="OK" --negative="" "Warning!"
And get a dialog with just the affirmative button. That's no longer the case. Now you get an empty negative button too.

To Reproduce
Just execute:
gum confirm --affirmative="OK" --negative="" "Warning!"

Expected behavior
Get a dialog with just the affirmative button.

Desktop (please complete the following information):

  • OS: Linux
  • Version v0.14.0
@maaslalani
Copy link
Contributor

Hey @txotxopue, thanks for the issue. This is fixed in huh and will be fixed in gum soon as well after we bump the dependency!

@aymanbagabas aymanbagabas added the bug Something isn't working label Jul 23, 2024
@bashbunni bashbunni added this to the v0.14.2 milestone Jul 23, 2024
@caarlos0
Copy link
Member

I think this is fixed on main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmd/confirm
Projects
None yet
Development

No branches or pull requests

5 participants