-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide
is not working
#130
Comments
The hide command will hide frames from being recorded not the actual content of what is being typed. That is why the README shows that the command is already typed and you do not see the typing in the GIF but the typing does occur on the terminal. |
Oh okay, got it! Is there any way to hide the full setup? Using the docker env I have to install some packages as they are not already in alpine (like curl), but I'd like to hide them from the user. |
Yep, do the Hide and all the typing and then clear the screen (by typing "clear" and Enter) |
Okay this seems to (kinda) work! The first few frames are still showing the output of |
Yes we'll definitely sort out the frames issue but to prevent it for now I think you can sleep for a little but after you've cleared the screen (but before the show) |
But yes soon we'll have it so theres not extra frames cutting in. That is definitely a bug! |
Works like a charmbracelet 😉 |
Just out of interest, why does This could probably be expanded to |
Oh interesting, that is a very good idea and would be quite useful, IMO. I generally agree that it is a little confusing what Hide does and maybe needs a bit more documentation or a rename. Maybe |
I'll leave the naming up to you, as I always struggle with it in my own projects 😆 Just another thing I noticed is, that with the This would also be handled then :) |
I too had trouble understanding it initially. |
Pause and Resume will probably be the least confusing. Interestingly they behave very similar to (Also for what it's worth: compressed video players have to do something similar when doing a seek to a frame between two keyframes: they have to pause the video decoder's output, send it the previous keyframe, followed by all frames up to the frame it wants to show, then re-enable output and only then send it the frame it wants to display) |
I solved the problem like this by running Hide
Type 'vhs_sandbox="$(mktemp -d)"' Enter
Type 'cd "$vhs_sandbox"' Enter
+ Type 'clear' Enter
Show
... |
I just noticed that
Hide
is not working on my machine using docker. The README looks like it too:The animation of the command "typing" is not there, but the command itself is. This makes it hard to use for setup, as the whole setup process is visible to the user.
The text was updated successfully, but these errors were encountered: