You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The following configuration in a tape file is parsed as invalid, despite being in the documentation as one of the valid options (Colorful, Rings, ColorfulRight, and RingsRight).
Set WindowBar RingsRight
Setup
OS macOS & Ubuntu
Shell zsh
Terminal Emulator Alacritty
Terminal Multiplexer none
To Reproduce
Add Set WindowBar RingsRight to a tape file
Run vhs
$ vhs test.tape
File: test.tape
3 │ Set WindowBar RingsRight
^^^^^^^^^^ RingsRight is not a valid bar style.
parser: 1 error(s)
recording failed
Source Code
$ cat test.tape
Output "demo.gif"
Set WindowBar RingsRight
Set FontSize 46
Set Width 1200
Set Height 600
Type echo 'Welcome to VHS!'
Sleep 500ms
Enter 1
Sleep 5s
Expected behavior
vhs should validate the tape file correctly and begin recording a gif.
// Check if a given windowbar type is valid
func isValidWindowBar(w string) bool {
return w == "" ||
w == "Colorful" || w == "ColorfulRight" ||
w == "Rings" || w == "RightsRight"
}
RightsRight should be RingsRight
The text was updated successfully, but these errors were encountered:
popey
linked a pull request
Nov 6, 2024
that will
close
this issue
Describe the bug
The following configuration in a tape file is parsed as invalid, despite being in the documentation as one of the valid options (Colorful, Rings, ColorfulRight, and RingsRight).
Set WindowBar RingsRight
Setup
To Reproduce
Set WindowBar RingsRight
to a tape filevhs
Source Code
Expected behavior
vhs should validate the tape file correctly and begin recording a gif.
Screenshots
Additional context
The issue is a typo in https://github.com/charmbracelet/vhs/blob/main/parser/parser.go#L771
RightsRight
should beRingsRight
The text was updated successfully, but these errors were encountered: