Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace req["user"] with req["userEntity"] in session-user.controller #546

Closed
2 tasks
eleanorreem opened this issue Jul 22, 2024 · 3 comments
Closed
2 tasks
Assignees
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days help wanted Extra attention is needed javascript Pull requests that update Javascript code maintenance Maintenance / chore work priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending.

Comments

@eleanorreem
Copy link
Contributor

eleanorreem commented Jul 22, 2024

Overview

Take a read through the umbrella ticket. As a sub task to this ticket we want to phase out the use of req["user"] from the session-user.controller.ts. The endpoints that need addressing are POST /session-user, POST /session-user/complete, POST /session-user/incomplete. Note that we haven't followed rest patterns here and hopefully this will be refactored at a later date but not part of this ticket.

Action Items

  • For each endpoint that uses req["user"], the service methods will need to be refactored to take the req["userEntity"] rather than req["user"]. This means the service methods will be taking userEntity rather than GetUserDto as its argument. The types need to be updated in the service method and adjustments will need to be made if they are used elsewhere.
  • Run all tests. This includes Cypress tests. You will need to load the frontend repository to get instructions about how this works. https://github.com/chaynHQ/bloom-frontend
@eleanorreem eleanorreem added complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending. maintenance Maintenance / chore work javascript Pull requests that update Javascript code labels Jul 22, 2024
@kyleecodes kyleecodes added the help wanted Extra attention is needed label Jul 23, 2024
@leoseg
Copy link
Contributor

leoseg commented Aug 1, 2024

Hi I would like to take up this issue, can you assign it to me? :)

Copy link

github-actions bot commented Aug 1, 2024

Thank you @leoseg you have been assigned this issue!
Please follow the directions in our Contributing Guide. We look forward to reviewing your pull request shortly ✨


Support Chayn's mission? ⭐ Please star this repo to help us find more contributors like you!
Learn more about Chayn here and explore our projects. 🌸

@leoseg
Copy link
Contributor

leoseg commented Aug 5, 2024

Hi I created the pull request :) #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days help wanted Extra attention is needed javascript Pull requests that update Javascript code maintenance Maintenance / chore work priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending.
Projects
None yet
Development

No branches or pull requests

3 participants