Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

health_check_interval is set to True, not number of seconds #880

Open
androa opened this issue Dec 19, 2023 · 1 comment
Open

health_check_interval is set to True, not number of seconds #880

androa opened this issue Dec 19, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@androa
Copy link
Contributor

androa commented Dec 19, 2023

The documentation of redis-py says health_check_interval is an int for the number of seconds between health checks or ping/pong.

health_check_interval=True,

I assume setting it to true would be the same as setting it to 1? Maybe 10, 30, or a configurable value would be better?

@androa androa changed the title Set health_check_interval to number of seconds health_check_interval is set to True, not number of seconds Dec 19, 2023
@chdsbd
Copy link
Owner

chdsbd commented Jan 12, 2024

I'm open to PRs supporting configuration for this setting.

For what it's worth, this health check interval works in production, even if it is a little too frequent

@chdsbd chdsbd added the enhancement New feature or request label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants