Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds incident.io channel #1026

Merged
merged 2 commits into from
Feb 25, 2025
Merged

feat: adds incident.io channel #1026

merged 2 commits into from
Feb 25, 2025

Conversation

tnolet
Copy link
Member

@tnolet tnolet commented Feb 24, 2025 •
edited
Loading

I hereby confirm that I followed the code guidelines found at engineering guidelines

Affected Components

  • CLI
  • Create CLI
  • Test
  • Docs
  • Examples
  • Other

Notes for the Reviewer

  • adds construct for Incident.io channel.
  • extends the base WebhookAlertChannel class.
  • tested locally already with actual incident.io integration. Firing and resolving works.

Resolves #1025

Note: construct reference in docs not updated yet.

@tnolet tnolet added this to the 5.0.x milestone Feb 24, 2025
@tnolet tnolet requested a review from sorccu February 24, 2025 15:07
@tnolet tnolet mentioned this pull request Feb 24, 2025
Open
6 tasks
tdeekens
tdeekens reviewed Feb 25, 2025
View reviewed changes
Copy link

@tdeekens tdeekens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot 🤗 .

sorccu
sorccu approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@sorccu sorccu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tnolet tnolet merged commit fbcaf1f into main Feb 25, 2025
3 checks passed
@tnolet tnolet deleted the tnolet/add-incidentio-channel branch February 25, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens left review comments

@sorccu sorccu sorccu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.

feat: Add support for incident.io Alert Channel
3 participants
@tnolet @sorccu @tdeekens