Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test data used during training #1

Open
philippemiron opened this issue Jul 3, 2023 · 1 comment
Open

test data used during training #1

philippemiron opened this issue Jul 3, 2023 · 1 comment
Assignees

Comments

@philippemiron
Copy link

Looking at the code in data.py:

idx = np.random.choice(train_data.shape[0], 1000, replace=False)
test_data = train_data[idx, :]
train_data = PinnDataset(train_data)
test_data = PinnDataset(test_data)

the testing data is used during training, this should be removed from the training dataset for appropriate testing of the model.

@chen-yingfa
Copy link
Owner

You are right, but this code is just an example for learning purposes, and the result should not be regarded as an evaluation of the methods. I will be updating this in a new commit though. Thanks.

@chen-yingfa chen-yingfa self-assigned this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants