Skip to content

Commit f772c75

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md
1 parent e750bb2 commit f772c75

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
Please do not create a Pull Request without creating an issue first.
2-
31
## What is the purpose of the change
42

53
XXXXX
@@ -12,11 +10,11 @@ XX
1210

1311
XXXX
1412

15-
Follow this checklist to help us incorporate your contribution quickly and easily:
13+
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
1614

17-
- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
18-
- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
19-
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
20-
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
21-
- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
15+
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
16+
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
17+
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
18+
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
19+
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
2220
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

0 commit comments

Comments
 (0)