Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Product Copyright when creating NuGet/Chocolatey packages #173

Closed
2 tasks done
AdmiringWorm opened this issue Jan 29, 2025 · 1 comment · Fixed by #176
Closed
2 tasks done

Use Product Copyright when creating NuGet/Chocolatey packages #173

AdmiringWorm opened this issue Jan 29, 2025 · 1 comment · Fixed by #176
Assignees
@AdmiringWorm
Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Milestone
0.29.0

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

There are several items that needs to be remembered whenever we change the copyright in our repositories, which could be handled automatically in a single place in the Chocolatey.Cake.Recipe.

Describe The Solution. Why is it needed?

When we initialize a new instance of the Chocoalatey.Cake.Recipe in a repository, we normally set the variable called productCopyright.

Since we are already setting this variable, it would be useful to make use of this variable to be able to automatically replace/update the copyright section specified in NuGet and Chocolatey packages, as well as when we are running DotNetCorePack (if it isn't already there).

Additional Context

No response

Related Issues

No response
@AdmiringWorm AdmiringWorm added the Bug Issues where something has happened which was not expected or intended label Jan 29, 2025
@AdmiringWorm AdmiringWorm added this to the 0.29.0 milestone Jan 31, 2025
@AdmiringWorm AdmiringWorm added Improvement Issues that enhances existing functionality, or adds new features and removed Bug Issues where something has happened which was not expected or intended labels Jan 31, 2025
@AdmiringWorm AdmiringWorm self-assigned this Feb 3, 2025
@AdmiringWorm AdmiringWorm added the 2 - Working A user or team member has started working on the issue label Feb 3, 2025
AdmiringWorm added a commit to AdmiringWorm/Chocolatey.Cake.Recipe that referenced this issue Feb 3, 2025
@AdmiringWorm
(chocolatey#173) Use Product Copyright for packages
057a5fa 
This updates the creation of Chocolatey and NuGet packages, as well as
other places that could potentially create packages (like during build
or publishing).

This is done by explicitly passing in the ProductCopyright parameter to
the locations responsible for creating packages.
@AdmiringWorm AdmiringWorm mentioned this issue Feb 3, 2025
Merged
10 tasks
AdmiringWorm added a commit to AdmiringWorm/Chocolatey.Cake.Recipe that referenced this issue Feb 3, 2025
@AdmiringWorm
(chocolatey#173) Use Product Copyright for packages
36b22d1 
This updates the creation of Chocolatey and NuGet packages, as well as
other places that could potentially create packages (like during build
or publishing).

This is done by explicitly passing in the ProductCopyright parameter to
the locations responsible for creating packages.
@AdmiringWorm AdmiringWorm added 3 - Review Code has been added, and is available for review as a pull request and removed 2 - Working A user or team member has started working on the issue labels Feb 3, 2025
AdmiringWorm added a commit to AdmiringWorm/Chocolatey.Cake.Recipe that referenced this issue Feb 3, 2025
@AdmiringWorm
(chocolatey#173) Use Product Copyright for packages
a2d21d1 
This updates the creation of Chocolatey and NuGet packages, as well as
other places that could potentially create packages (like during build
or publishing).

This is done by explicitly passing in the ProductCopyright parameter to
the locations responsible for creating packages.
gep13 added a commit that referenced this issue Feb 3, 2025
@gep13
Merge pull request #176 from AdmiringWorm/Use-Product-Copyright-when-…
e0dd730 
…creating-NuGetChocolatey-packages-173

(#173) Use Product Copyright for packages
@gep13 gep13 closed this as completed in #176 Feb 3, 2025
@gep13 gep13 added 4 - Done Code has been added to the repository, and has been reviewed by a team member and removed 3 - Review Code has been added, and is available for review as a pull request labels Feb 3, 2025
gep13 added a commit that referenced this issue Feb 4, 2025
@gep13
Merge branch 'develop'
07c524f 
* develop:
  (#167) Update to latest GitReleaseManager
  (#174) Don't always push latest tag to docker
  (#181) Make ILMerge depend on Build and Test
  (#157) Fix PowerShell signing up to date throws exception
  (#135) Include support for Publish Release Task
  (#132) Fix name of release notes task
  (#164) Use version number in URLs
  (#136) Allow dry run of task
  (maint) Fixed spelling mistake
  (#173) Use Product Copyright for packages
  (#134) Correct target branch for support branches
  (GH-171) Bump DependencyCheck version
  (GH-171) Enable Dependency-Check central DB
  (#162) Rework prerelease substring
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels Feb 4, 2025
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.29.0 🎉

The release is available on:

Your GitReleaseManager bot 📦 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
5 - Released The issue has been resolved, and released to the public for consumption Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Milestone
0.29.0
Development

Successfully merging a pull request may close this issue.

(#173) Use Product Copyright for packages AdmiringWorm/Chocolatey.Cake.Recipe
3 participants
@gep13 @AdmiringWorm @choco-bot