Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#1) (ENGTASKS-3631) Add Astro dependencies #2

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

st3phhays
Copy link
Member

Description Of Changes

This fixes up Astro to get it to a state where it
is meant to be to install the dependencies as a
package. Workflows have been added that are
very similar to choco-theme. Once deployed to
NPM, this can be installed by running yarn add choco-astro.

Motivation and Context

This consolidates all the dependencies into one package that we can use across multiple projects.

Testing

TBD.

Operating Systems Testing

n/a

Change Types Made

  • Bug fix (non-breaking change).
  • Feature / Enhancement (non-breaking change).
  • Breaking change (fix or feature that could cause existing functionality to change).
  • Documentation changes.
  • PowerShell code changes.

Change Checklist

  • Requires a change to the documentation.
  • Documentation has been updated.
  • Tests to cover my changes, have been added.
  • All new and existing tests passed?
  • PowerShell code changes: PowerShell v2 compatibility checked?

Related Issue

@st3phhays st3phhays self-assigned this May 17, 2024
@st3phhays
Copy link
Member Author

This is in draft because it will need to be tested against docs before merged.

@st3phhays st3phhays force-pushed the astro branch 8 times, most recently from 76aee94 to e89c456 Compare May 19, 2024 18:08
st3phhays added 2 commits May 19, 2024 13:11
This installs a brand new Astro project to
build off of.
This switches to use Yarn 4 instead of Yarn 1.
@st3phhays st3phhays force-pushed the astro branch 6 times, most recently from 21f8eea to 212e8fb Compare May 21, 2024 17:10
@st3phhays st3phhays force-pushed the astro branch 2 times, most recently from 721a1da to c2f47ae Compare June 4, 2024 15:27
@st3phhays st3phhays changed the title (#1) Add Astro dependencies (#1) Add Astro dependencies (ENGTASKS-3631) Jun 4, 2024
@st3phhays st3phhays changed the title (#1) Add Astro dependencies (ENGTASKS-3631) (#1) (ENGTASKS-3631) Add Astro dependencies Jun 4, 2024
@st3phhays st3phhays force-pushed the astro branch 2 times, most recently from 7935952 to 463acca Compare June 6, 2024 16:42
@st3phhays st3phhays requested a review from gep13 June 6, 2024 18:33
@st3phhays st3phhays force-pushed the astro branch 2 times, most recently from 88dcfda to f9acd73 Compare June 10, 2024 18:03
Copy link
Member

@gep13 gep13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@st3phhays st3phhays marked this pull request as ready for review June 11, 2024 21:09
This fixes up Astro to get it to a state where it
is meant to be to install the dependencies as a
package. Workflows have been added that are
very similar to choco-theme. Once deployed to
NPM, this can be installed by running `yarn add
choco-astro`.
@gep13 gep13 merged commit 557a90f into chocolatey:main Jun 12, 2024
@gep13
Copy link
Member

gep13 commented Jun 12, 2024

@st3phhays let's get this show on the road...

Thanks for pulling all this together!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants