install: Enabled installing binary dependencies. Fix some memory issues.

Author: nouwaarom

.github/workflows/tests.yml

@@ -40,7 +40,7 @@ jobs:
       shell: bash
       run: |
         mkdir -p dockcross
-        sudo docker run --rm dockcross/windows-static-64-posix > dockcross-windows-x64
+        sudo docker run --rm dockcross/windows-x64 > dockcross-windows-x64
         cat dockcross-windows-x64
         chmod +x dockcross-windows-x64
         wget https://curl.haxx.se/download/curl-7.76.0.tar.gz
@@ -52,4 +52,4 @@ jobs:
     - name: Run Tests
       run: |
         ## if builds pass then its passing for now
-        ./dockcross-windows-x64 make all NO_PTHREADS=1 STATIC=true EXE=true
+        ./dockcross-windows-x64 make all STATIC=true EXE=true

deps/url/url.c

@@ -175,7 +175,7 @@ url_parse (const char *url) {
   int pathname_len = (int)strlen(pathname);
   data->pathname = pathname;
 
-  char *search = (char *) malloc(sizeof(search));
+  char *search = (char *) malloc(strlen(tmp_path)+1);
   if (!search) {
     free(tmp_url);
     url_free(data);
@@ -190,7 +190,7 @@ url_parse (const char *url) {
   int search_len = (int)strlen(search);
   free(tmp_path);
 
-  char *query = (char *) malloc(sizeof(char));
+  char *query = (char *) malloc(search_len+1);
   if (!query) {
     free(tmp_url);
     url_free(data);
@@ -199,7 +199,7 @@ url_parse (const char *url) {
   sscanf(search, "?%s", query);
   data->query = query;
 
-  char *hash = (char *) malloc(sizeof(char));
+  char *hash = (char *) malloc(strlen(path)+1);
   if (!hash) {
     free(tmp_url);
     url_free(data);

src/clib-build.c

@@ -193,7 +193,7 @@ int build_package_with_manifest_name(const char *dir, const char *file) {
 #endif
   } else {
 #ifdef DEBUG
-    package = clib_package_new_from_slug(dir, 1);
+    package = clib_package_new_from_slug_and_url(dir, "FIXME", 1);
 #else
     package = clib_package_new_from_slug_and_url(dir, "FIXME", 0);
 #endif

src/clib-configure.c

@@ -186,7 +186,7 @@ int configure_package_with_manifest_name(const char *dir, const char *file) {
 #endif
   } else {
 #ifdef DEBUG
-    package = clib_package_new_from_slug(dir, 1);
+    package = clib_package_new_from_slug_and_url(dir, "FIXME", 1);
 #else
     package = clib_package_new_from_slug_and_url(dir, "FIXME", 0);
 #endif

src/clib-settings.h

@@ -195,6 +195,7 @@ int clib_package_install_executable(clib_package_t *pkg, const char *dir, int ve
   E_FORMAT(&file, "%s-%s.tar.gz", reponame, pkg->version);
   E_FORMAT(&tarball, "%s/%s", tmp, file);
 
+  // TODO, move to repository
   rc = http_get_file(url, tarball, NULL, 0);
 
   if (0 != rc) {
@@ -517,6 +518,7 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
     repository_file_free(handles[j]);
   }
 #endif
+  free(handles);
 
 #ifdef HAVE_PTHREADS
   pthread_mutex_lock(&lock.mutex);
@@ -539,10 +541,9 @@ int clib_package_install(clib_package_t *pkg, const char *dir, int verbose) {
       goto cleanup;
   }
 
-  // TODO, check if we want to enable this.
-  //if (pkg->install) {
-  //  rc = clib_package_install_executable(pkg, dir, verbose);
-  //}
+  if (pkg->install) {
+    rc = clib_package_install_executable(pkg, dir, verbose);
+  }
 
   if (0 == rc) {
     rc = clib_package_install_dependencies(pkg, dir, verbose);