Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable sort #109

Open
aseemk opened this issue Dec 8, 2017 · 0 comments
Open

Stable sort #109

aseemk opened this issue Dec 8, 2017 · 0 comments

Comments

@aseemk
Copy link

aseemk commented Dec 8, 2017

Hi folks,

Great work on gen — it's very useful.

I'm unclear on whether Sort(By) is a stable sort or not. The code docs say the code is a modified version of https://golang.org/pkg/sort/#Sort — which is not stable. Is that still the case in this modified version? (Would be great to document this either way.)

If so, would it be possible to add stable versions of Sort and SortBy. The latter would be particularly helpful since the sort.Interface can't be code-gen'ed automatically for types that aren't naturally comparable.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant