Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit changes to upstream Vim #10

Closed
axvr opened this issue Jan 10, 2021 · 1 comment
Closed

Submit changes to upstream Vim #10

axvr opened this issue Jan 10, 2021 · 1 comment
Labels
upstream Upstream changes to Vim, Neovim and other plugins

Comments

@axvr
Copy link
Member

axvr commented Jan 10, 2021

We should consider submitting the latest changes for inclusion in Vim soon (preferably sometime before Vim 9 is released).

For this we will need to:

  1. merge all open PRs which we want included,
  2. test for regressions (I haven't found any yet),
  3. write a summary of the included changes,
  4. generate the patch (there is a comment in generate.clj on how to do this),
  5. send the patch and summary (with a mention of the maintainership change) to the Vim-dev mailing list (+ CC @guns in the email),
  6. await feedback.

NOTE: apparently it is now possible to open a pull request in the Vim GitHub repository instead of sending an email as that will automatically send the email and run the CI tests.

Open questions:

  1. Should we also submit these changes to Neovim? (Does Neovim do it the same way?)
@axvr
Copy link
Member Author

axvr commented Feb 13, 2021

See PR vim/vim#7830.

Edit: merged in vim/vim@942db23

@axvr axvr closed this as completed Feb 16, 2021
@axvr axvr added the upstream Upstream changes to Vim, Neovim and other plugins label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream Upstream changes to Vim, Neovim and other plugins
Projects
None yet
Development

No branches or pull requests

1 participant