-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyword and Symbol prefix matching #27
Conversation
Excellent! Thanks for this. I will take a look at it (and test it) in the next few days and hopefully we can get it merged soon. |
(Also the syntax tests are failing, but as they are still quite complicated, I'm happy to fix them for you once I test it myself and confirm that this PR is good and won't require additional changes.) |
I didn't know about syntax tests, oops :D Probably it's described in the README but I didn't read most of it. |
I fixed tests. |
Edit: Found that I used a theme package that had old themes |
I found that I had messed up the tests so I fixed them by editing the test macro. And one more problem that I face is that I can't greedily match It also decides to split the keyword into many parts and that's also bad. Not greedy enough. |
Something's glitched on GitHub's PR checks, it won't run the CI again :( so I can't merge through the UI. I'll merge it manually. |
Merged. Thank you for working on this! Also see: #24 (comment) |
This adds prefix matching to the keywords and symbols but not to namespaced functions (I may add this later, not sure how yet)
The default highlighting is not too obtrusive (it's possible to match symbol's and keyword's namespace but they're left to be the same as the item itself (symbol is white-on-white in this colorscheme as it's regarded to as Normal already)):