Remove private field access from generate ns #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Unicode standard files for regex categories, blocks and scripts, and just hardcode POSIX, Java and binary regex properties.
Deraen
force-pushed
the
remove-generate-private-field-access
branch
from
4c8eb0c to
ff77d5e
Compare
axvr
approved these changes
Dec 31, 2020
|
@Deraen, is this ready to be merged? It's been working perfectly for me. |
|
Yeah I've also been using this branch myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Unicode standard files for regex categories, blocks and scripts,
and just hardcode POSIX, Java and binary regex properties.
In Java 15 categories etc. are handled with a switch case, so we can't get list of them using reflection: https://github.com/openjdk/jdk/blob/4d13bf33d4932cc210a29c4e3a68f848db18575b/src/java.base/share/classes/java/util/regex/CharPredicates.java#L267
Related #3