Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Guide: Add prettier/eslint editor instructions #28

Open
calebeby opened this issue Jul 12, 2018 · 10 comments
Open

JS Guide: Add prettier/eslint editor instructions #28

calebeby opened this issue Jul 12, 2018 · 10 comments

Comments

@calebeby
Copy link
Member

calebeby commented Jul 12, 2018

I want to add a guide that tells you how to set up Prettier and ESLint in VSCode and maybe other editors. Would it be better to do it in this repo or in https://github.com/cloudfour/eslint-config?

@calebeby calebeby changed the title Update JS style guide/prettier/eslint stuff Update JS style guide/prettier/eslint instructions Jul 12, 2018
@gerardo-rodriguez
Copy link
Member

I love this and great question @calebeby!

More questions that come to mind. If I were a user that wanted to install/use @cloudfour/eslint-config, do I care/want instructions for only how to set up in the codebase? Is the expectation that I also get details on how to set it up in an editor?

It feels as though I don't expect to have instructions on how to add these tools in my editor. But that's not to say I wouldn't appreciate it. Hmm...dilemna. 🤔

Either way, I love the idea and I don't think you should let this be a blocker.

If I had to choose right now, I'd choose to add something to this repo. Reason being, regardless of which eslint config I choose to use (maybe there's a client project where we don't use @cloudfour/eslint-config), I can reference these guides here to configure my editor and it doesn't have to be specific to @cloudfour/eslint-config.

@cloudfour/dev @cloudfour/design Any thoughts?

@calebeby
Copy link
Member Author

Yeah @gerardo-rodriguez that seems reasonable.

@gerardo-rodriguez
Copy link
Member

Blarg...now I'm backing up on my original feeling.

But that's not to say I wouldn't appreciate it.

Now I'm feeling, if someone uses @cloudfour/eslint-config, they might appreciate an "oh hey, here's how to set these tools up in your editor also". I'm feeling too many feelings. I'm so torn. 🙈 😅

Any thoughts @tylersticka?

@calebeby
Copy link
Member Author

calebeby commented Jul 12, 2018

What if I put the guide here but I add a link from the eslint-config README to here?

@gerardo-rodriguez
Copy link
Member

Ha! Linking on the interwebs, what a novel idea! I like it! Works for me!

@gerardo-rodriguez
Copy link
Member

@calebeby Is this GH issue related to your comment here?

@calebeby
Copy link
Member Author

calebeby commented Nov 7, 2018

I think this issue was more related to setting up editors.

@spaceninja
Copy link
Member

@calebeby this is done, right?

@spaceninja spaceninja changed the title Update JS style guide/prettier/eslint instructions JS Guide: add prettier/eslint instructions Mar 19, 2019
@spaceninja spaceninja changed the title JS Guide: add prettier/eslint instructions JS Guide: Add prettier/eslint editor instructions Mar 19, 2019
@calebeby
Copy link
Member Author

@spaceninja I don't think I ever got around to this.

@spaceninja
Copy link
Member

@calebeby (facepalm) I just realized I totally misread the title title. This is about adding instructions for using eslint/prettier in your editor, which, yeah, you're right, isn't done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants