Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Venue account sign up #53

Closed
8 of 10 tasks
ctrembath opened this issue Sep 6, 2018 · 23 comments
Closed
8 of 10 tasks

Venue account sign up #53

ctrembath opened this issue Sep 6, 2018 · 23 comments
Labels
please-test priority-3 question Further information is requested T4h Vicky - Venue User: Vicky, Venue manager

Comments

@ctrembath
Copy link
Collaborator

ctrembath commented Sep 6, 2018

As a venue,
I'd like to sign up with my email address and password,
so I can get listed on the Club Soda Guide and attract mindful drinkers to my venue.

Acceptance Criteria

  • As a Venue I would like to enter my email address into a field
    • when a new venue is created, automatically login the new user
  • As a Venue I would like to create a password
  • As a Venue I would like to confirm my password
  • As a Venue I would like to receive an email asking me to confirm my email address
  • Opt-in consent is obtained and if this box Cookies & GDPR #82
    • Friendly error message is displayed if consent checkbox is not ticked and venues cannot sign up

@iteles, speaking with @jussi-club-soda after our call - the venue sign up with email/password might be less of a priority given that we expect venues to create their listing and not necessarily log back in. We believe it would be more useful to be able to send venues personalised email notifications.
Without log in details can you see a way that venues could update their stocklist / images / description?

@ctrembath ctrembath changed the title Venue sign up Venue account sign up Sep 6, 2018
@iteles
Copy link
Contributor

iteles commented Sep 7, 2018

Note: GDPR opt-in consent needs to be taken into consideration for acceptance criteria.

@Danwhy Danwhy mentioned this issue Sep 11, 2018
2 tasks
@iteles iteles added the Vicky - Venue User: Vicky, Venue manager label Sep 26, 2018
@Cleop Cleop self-assigned this Oct 1, 2018
@Cleop
Copy link
Collaborator

Cleop commented Oct 1, 2018

<< Currently in discussion >>

The proposed venue sign up process is:

login details (email/password) > basic venue details > done?

Other elements of the flow are: adding more detail at a later date e.g. venue description/photo etc and adding drinks that the venue stocks.

  • Is this flow for both venues and the public or just one?
  • Should venues be able to add more detail straight away (how?) or how do they do this? How does this part of the flow not put off people who just wanted to help out with the basics e.g. public customer who won't fill in the extra detail?

The minimum fields needed for a venue sign up user sign up stage:

  • email

Proposed other fields:

  • password
  • password entered twice
  • email confirmation email

The minimum fields needed for a venue sign up details stage:

  • Venue name
  • Venue address (to check for duplicates/ if the venue already exists on the system)
  • Type of venue e.g. bar, pub etc.
  • Phone number (I wonder what the relevance of phone number is over e.g. website)

Intitial implementation:

I feel that for the initial user sign up the email confirmation is not necessary. As Suhail Doshi (https://youtu.be/MABmQhOlmJA), Mixpanel founder suggests, it will create a large drop off of sign ups. Until spam etc. becomes a problem, at an MVP stage I would not suggest this is a priority. Not including it will improve conversion rates and free up developer time. We can test whether users are opposed to sign ups without this but this is my preferred implementation.

@Danwhy Danwhy self-assigned this Oct 2, 2018
Cleop added a commit that referenced this issue Oct 2, 2018
Cleop added a commit that referenced this issue Oct 2, 2018
Cleop added a commit that referenced this issue Oct 2, 2018
Cleop added a commit that referenced this issue Oct 3, 2018
Cleop added a commit that referenced this issue Oct 4, 2018
@Cleop Cleop removed the in-progress label Oct 15, 2018
@Cleop Cleop removed their assignment Jan 14, 2019
@iteles iteles mentioned this issue Feb 7, 2019
3 tasks
@jussi-club-soda
Copy link
Collaborator

Message from AWS:
Your new sending quota is 50,000 messages per day. Your maximum send rate is now 14 messages per second. We have also moved your account out of the Amazon SES sandbox.
This takes effect immediately in the EU (Ireland) region. You can view the current sending rate and sending quota for your account on the Sending Statistics page of the Amazon SES console, or by using the GetSendQuota API.

Have also just updated the credentials in the Google doc!

cc @RobStallion @jessyclubsoda

@RobStallion
Copy link
Contributor

@jussi-club-soda Thanks for updating the doc with the info. I have just tested locally and they seem to be working as expected.

Update the staging area now so it should all be working now.

@jessyclubsoda you should now be able to go to the forgotten password path and get an email sent to your address.

Let me know if you have any problems or questions.

@jessyclubsoda
Copy link
Contributor

All working for me!

@jessyclubsoda
Copy link
Contributor

@RobStallion Will all new venues have to go down the Forgotten Password path to get a password or will it be an option to set up a password when you sign up?

@RobStallion
Copy link
Contributor

@jessyclubsoda When a new venue signs up, they will be logged in automatically so that they can use the site as you would expect. They will also be sent an email at that time to confirm their account, which will take them the page to set a password.

The only reason you had to go to the forgotten password path was because you had a venue set up before the email functionality was working properly (so you never received the email when your venue was created)

@jessyclubsoda
Copy link
Contributor

@RobStallion Is the email confirmation to set up password all good to go too?

@jessyclubsoda jessyclubsoda added question Further information is requested and removed please-test labels Apr 4, 2019
@RobStallion
Copy link
Contributor

RobStallion commented Apr 4, 2019

@jessyclubsoda Yeah that functionality is working and you should be able to test it in staging. I know you tried yesterday and didn't receive the email but it was before the credentials were changed.

If you try setting up another venue now with a different email address you should receive the email to confirm your account 👍

However, at the moment the opt-in consent which is part of the acceptance criteria for this issue still needs to be completed. I know that this is being worked on at the moment in #82.

RobStallion added a commit that referenced this issue Apr 4, 2019
RobStallion added a commit that referenced this issue Apr 4, 2019
RobStallion added a commit that referenced this issue Apr 4, 2019
@jessyclubsoda
Copy link
Contributor

Sorry one more question @RobStallion Will there be a login button at any point?

@nelsonic
Copy link
Contributor

nelsonic commented Apr 4, 2019

@ctrembath is there an issue, acceptance criteria or design wireframe indicating where the Login button should be?

@jessyclubsoda
Copy link
Contributor

@nelsonic No it doesn't look like we do. Can we just place it in the same place as where the 'Log out' button goes once someone is logged in?

@nelsonic
Copy link
Contributor

nelsonic commented Apr 4, 2019

@jessyclubsoda we agree that placing the login button in the Top Nav could be a good option.
It's worth having a dedicated issue for the Login button (rather than including new requirements in the comments of this issue...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
please-test priority-3 question Further information is requested T4h Vicky - Venue User: Vicky, Venue manager
Projects
None yet
Development

No branches or pull requests

8 participants