Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special icon for external links #2481

Open
shurup opened this issue Oct 10, 2023 · 3 comments
Open

Special icon for external links #2481

shurup opened this issue Oct 10, 2023 · 3 comments
Labels
enhancement New feature or request maintainers Use this label if PR requires maintainers to take action triage/awaiting new term proposal is under evaluation process

Comments

@shurup
Copy link
Collaborator

shurup commented Oct 10, 2023

Most of the links we have now in the Glossary articles are internal, i.e. leading to other Glossary articles, thanks to interlinking all terms praised by the style guide. However, there might exist some external links as well. E.g., we have a link to the OCI website in the Containerization article:

image

I guess that most users won't expect to be sent to another website when clicking on such a link — since they get used to mostly internal linking across the Glossary. Thus, I suggest adding a special icon for all external links to tell users this link is external.

@shurup shurup added enhancement New feature or request maintainers Use this label if PR requires maintainers to take action triage/awaiting new term proposal is under evaluation process labels Oct 10, 2023
@justankiit
Copy link
Contributor

Hey @jihoon-seo, Should I work on this!

@jihoon-seo
Copy link
Collaborator

@kumarankit999 Please wait for other maintainers to triage this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintainers Use this label if PR requires maintainers to take action triage/awaiting new term proposal is under evaluation process
Projects
None yet
Development

No branches or pull requests

3 participants