Skip to content

Commit ea5c37b

Browse files
author
Dan Avery
committed
reverting accidental trunk commit to rev 810
1 parent f99863d commit ea5c37b

File tree

9 files changed

+18
-47
lines changed

9 files changed

+18
-47
lines changed

lib/oai/constants.rb

-4
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,6 @@ module Delete
2929
PERSISTENT = :persistent
3030
end
3131

32-
module Strict
33-
STRICT = :strict
34-
LAX = :lax
35-
end
3632
end
3733

3834
end

lib/oai/provider.rb

+2-4
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ class Base
184184

185185
class << self
186186
attr_reader :formats
187-
attr_accessor :name, :url, :prefix, :email, :delete_support, :granularity, :model, :strict
187+
attr_accessor :name, :url, :prefix, :email, :delete_support, :granularity, :model
188188

189189
def register_format(format)
190190
@formats ||= {}
@@ -218,7 +218,6 @@ def inherited(klass)
218218
alias_method :deletion_support, :delete_support=
219219
alias_method :update_granularity, :granularity=
220220
alias_method :source_model, :model=
221-
alias_method :strict_mode, :strict=
222221

223222
end
224223

@@ -229,7 +228,6 @@ def inherited(klass)
229228
Base.admin_email 'nobody@localhost'
230229
Base.deletion_support OAI::Const::Delete::TRANSIENT
231230
Base.update_granularity OAI::Const::Granularity::HIGH
232-
Base.strict_mode OAI::Const::Strict::LAX
233231

234232
Base.register_format(OAI::Provider::Metadata::DublinCore.instance)
235233

@@ -278,7 +276,7 @@ def process_request(params = {})
278276

279277
# Allow the request to pass in a url
280278
self.class.url = params['url'] ? params.delete('url') : self.class.url
281-
279+
282280
verb = params.delete('verb') || params.delete(:verb)
283281

284282
unless verb and OAI::Const::VERBS.keys.include?(verb)

lib/oai/provider/response/get_record.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
module OAI::Provider::Response
22

33
class GetRecord < RecordResponse
4-
required_parameters :identifier, :metadataPrefix
4+
required_parameters :identifier
55

66
def to_xml
77
id = extract_identifier(options.delete(:identifier))

lib/oai/provider/response/list_identifiers.rb

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module OAI::Provider::Response
22

33
class ListIdentifiers < RecordResponse
44

5-
required_parameters :metadataPrefix
6-
75
def to_xml
86
result = provider.model.find(:all, options)
97

lib/oai/provider/response/list_records.rb

-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@ module OAI::Provider::Response
22

33
class ListRecords < RecordResponse
44

5-
required_parameters :metadataPrefix
6-
75
def to_xml
86
result = provider.model.find(:all, options)
97
# result may be an array of records, or a partial result

lib/oai/provider/response/record_response.rb

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ module OAI::Provider::Response
22
class RecordResponse < Base
33

44
def self.inherited(klass)
5-
klass.valid_parameters :from, :until, :set
6-
klass.default_parameters
5+
klass.valid_parameters :metadata_prefix, :from, :until, :set
6+
klass.default_parameters :metadata_prefix => "oai_dc",
77
:from => Proc.new {|x| Time.parse(x.provider.model.earliest.to_s) },
88
:until => Proc.new {|x| Time.parse(x.provider.model.latest.to_s) }
99
end
0 Bytes
Binary file not shown.

test/provider/tc_exceptions.rb

-9
Original file line numberDiff line numberDiff line change
@@ -60,13 +60,4 @@ def test_no_records_match_bad_set
6060
assert_raise(OAI::NoMatchException) { @provider.list_records(:set => 'unknown') }
6161
end
6262

63-
def test_no_metadata_prefix_on_record_request_raises_exception
64-
assert_raise(OAI::ArgumentException) { @provider.process_request(:verb => "ListRecords") }
65-
end
66-
67-
def test_bad_character_raises_exception
68-
assert_raise(OAI::ArgumentException) do
69-
@provider.process_request(:verb => "GetRecord", :metadataPrefix => "oai_dc", :identifier => "bad\"id")
70-
end
71-
end
7263
end

tools/generate_fixtures.rb

+13-23
Original file line numberDiff line numberDiff line change
@@ -2,33 +2,23 @@
22
#
33
# Created by William Groppe on 2007-01-17.
44
require 'yaml'
5-
require 'rubygems'
6-
require 'chronic'
75

86
# Dublin Core fields
97
FIELDS = %w{title creator subject description contributor publisher
108
date type format source language relation coverage rights}
119

12-
unless ARGV[0]
13-
puts "Please specify how many records to generate."
14-
exit
15-
end
10+
unless ARGV[0]
11+
puts "Please specify how many records to generate."
12+
exit
13+
end
14+
15+
# Hash for records
16+
records = {}
1617

17-
# Hash for records
18-
records = {}
19-
20-
ARGV[0].to_i.times do |i|
21-
records[i] =
22-
Hash[*FIELDS.collect { |field|
23-
# date is a special case--we want a real date in the records
24-
if field == "date"
25-
record_date = Chronic.parse("#{i} days ago")
26-
[field, "#{record_date}"]
27-
else
28-
[field, "#{field}_#{i}"]
29-
end
30-
} .flatten]
31-
end
32-
33-
puts records.to_yaml
18+
ARGV[0].to_i.times do |i|
19+
records[i] =
20+
Hash[*FIELDS.collect { |field| [field, "#{field}_#{i}"] }.flatten]
21+
end
3422

23+
puts records.to_yaml
24+

0 commit comments

Comments
 (0)