Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codemod] Test coverage of CLI could be improved #1407

Open
spirulence opened this issue Dec 10, 2024 · 1 comment
Open

[codemod] Test coverage of CLI could be improved #1407

spirulence opened this issue Dec 10, 2024 · 1 comment
Assignees
Labels

Comments

@spirulence
Copy link
Contributor

Issue Description

Select one of:
[ ] Generated codemod is not correct
[ ] Bug in Codemod Studio
[ ] UI/UX improvement request
[X] Feature request

Unit test coverage on the CLI package could be better, to help contributors prevent regressions. Results of npx vitest --coverage on a recent main commit f3fc6be
CleanShot 2024-12-10 at 15 26 59

Steps to Reproduce

  1. Navigate to the CLI folder - apps/cli
  2. Run npx vitest --coverage

Actual Results

Test coverage is sitting between 3% and 42%, depending on which metric is the most important.

Expected Results

I'd love to see metrics > 60% across all of these metrics: statements, branches, functions, and lines. My prior experience suggests that there are diminishing returns above 70%, in terms of the effort required to get there and the effort then required to rewrite those tests as other code changes.

I would love to hear from the community if this is a worthwhile goal. I have one PR ready to merge that improves this, and others can likely come piecemeal.

Technical details

  • NodeJS 20
@spirulence spirulence changed the title [cli] Test coverage of CLI could be improved [codemod] Test coverage of CLI could be improved Dec 10, 2024
@alexbit-codemod
Copy link
Contributor

chatted with Mo... assigning this to our awesome intern, amirabbas...

THANK YOU cameron. you are a champ. very grateful to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants