flake: TestWorkspaceUpdateTTL

[mafredri]

    workspaces_test.go:2503: 
        	Error Trace:	/home/runner/work/coder/coder/coderd/workspaces_test.go:2503
        	            				/home/runner/work/coder/coder/coderd/workspaces_test.go:2553
        	Error:      	Should not be zero, but was {{0001-01-01 00:00:00 +0000 UTC false}}
        	Test:       	TestWorkspaceUpdateTTL/ModifyAutostopWithRunningWorkspace/IncreaseAutostopDoesNotModifyDeadline

Seen at: https://github.com/coder/coder/actions/runs/13943382083/job/39024931983?pr=16996#step:7:611

[DanielleMaywood]

I can get this to reproduce locally, although I haven't got a fix yet but want to note down my findings:

• The workspace does correctly have a TTL set on it
• The workspace build does not have a deadline set

Could it be possible that sometimes workspace builds can be created without a deadline?

[DanielleMaywood]

It appears if I add a sleep in the test it stops failing.

The AwaitWorkspaceBuildJobCompleted waits until the job's CompletedAt != nil. Is it possible that the Deadline is changed after CompletedAt != nil?

[mafredri]

Perhaps workspace activity could trigger an updated deadline?