Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-web: auto installing extensions fails if json has comments #385

Closed
edaily opened this issue Jan 21, 2025 · 0 comments · Fixed by #398
Closed

vscode-web: auto installing extensions fails if json has comments #385

edaily opened this issue Jan 21, 2025 · 0 comments · Fixed by #398
Assignees
@matifali

Comments

@edaily
Copy link

edaily commented Jan 21, 2025

When using the vscode-web module with auto_install_extensions set to true extensions will fail if your repo's .vscode/extensions.json file contains comments.

This appears to be because run.sh executes jq (which doesn't directly support json with comments) against the file (see here). Comments in .vscode/extensions.json are fairly common (for example, see the extensions.json in the vscode repo).
@coder-labeler coder-labeler bot added docs Improvements or additions to documentation help wanted Extra attention is needed labels Jan 21, 2025
@matifali matifali removed docs Improvements or additions to documentation help wanted Extra attention is needed labels Feb 5, 2025
@matifali matifali self-assigned this Feb 6, 2025
@matifali matifali mentioned this issue Feb 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle extensions.json comments in vscode-web and code-server coder/modules
2 participants
@matifali @edaily