Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 14496f6

Browse files
authored
Merge pull request #628 from codestoryai/features/return-parsable-diagnostics
[side] return parsable diagnostics
2 parents c91630d + 2672192 commit 14496f6

File tree

2 files changed

+37
-4
lines changed

2 files changed

+37
-4
lines changed

extensions/codestory/src/server/diagnostics.ts

+20-3
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,29 @@
44
*--------------------------------------------------------------------------------------------*/
55

66
import * as vscode from 'vscode';
7+
import { SidecarDiagnostics } from './types';
78

8-
export function getDiagnosticsFromEditor(filePath: string, interestedRange: vscode.Range): vscode.Diagnostic[] {
9+
export function getDiagnosticsFromEditor(filePath: string, interestedRange: vscode.Range): SidecarDiagnostics[] {
910
const fileUri = vscode.Uri.file(filePath);
1011
const diagnostics = vscode.languages.getDiagnostics(fileUri);
11-
diagnostics.filter((diagnostic) => {
12+
const sidecarDiagnostics = diagnostics.filter((diagnostic) => {
1213
return interestedRange.contains(diagnostic.range);
14+
}).map((diagnostic) => {
15+
return {
16+
diagnostic: diagnostic.message,
17+
range: {
18+
startPosition: {
19+
line: diagnostic.range.start.line,
20+
character: diagnostic.range.start.character,
21+
byte_offset: 0,
22+
},
23+
endPosition: {
24+
line: diagnostic.range.end.line,
25+
character: diagnostic.range.end.character,
26+
byte_offset: 0,
27+
},
28+
},
29+
};
1330
});
14-
return diagnostics;
31+
return sidecarDiagnostics;
1532
}

extensions/codestory/src/server/types.ts

+17-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ export type SidecarApplyEditsRequest = {
115115
character: number;
116116
};
117117
};
118-
}
118+
};
119119

120120
export type SidecarApplyEditsResponse = {
121121
fs_file_path: string;
@@ -133,3 +133,19 @@ export type SidecarApplyEditsResponse = {
133133
};
134134
};
135135
};
136+
137+
export type SidecarDiagnostics = {
138+
diagnostic: string;
139+
range: {
140+
startPosition: {
141+
line: number;
142+
character: number;
143+
byte_offset: number;
144+
};
145+
endPosition: {
146+
line: number;
147+
character: number;
148+
byte_offset: number;
149+
};
150+
};
151+
};

0 commit comments

Comments
 (0)