Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 56db61e

Browse files
authored
chore: update remote node.js (#213439)
* chore: update remote node.js to v20.11.1 * chore: remove io_uring workaround * chore: update checksums * temp: update distro * ci: rebuild cache * chore: bump distro
1 parent 6749a5a commit 56db61e

File tree

7 files changed

+13
-33
lines changed

7 files changed

+13
-33
lines changed

build/.cachesalt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2024-05-16T14:24:05.381Z
1+
2024-05-25T03:29:59.419Z

build/azure-pipelines/linux/product-build-linux-test.yml

-16
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,6 @@ steps:
100100
timeoutInMinutes: 20
101101

102102
- script: ./scripts/test-remote-integration.sh
103-
env:
104-
# TODO(deepak1556): Remove this once we update to Node.js >= 20.11.x
105-
UV_USE_IO_URING: 0
106103
displayName: Run integration tests (Remote)
107104
timeoutInMinutes: 20
108105

@@ -137,8 +134,6 @@ steps:
137134
./scripts/test-remote-integration.sh
138135
env:
139136
VSCODE_REMOTE_SERVER_PATH: $(agent.builddirectory)/vscode-server-linux-$(VSCODE_ARCH)
140-
# TODO(deepak1556): Remove this once we update to Node.js >= 20.11.x
141-
UV_USE_IO_URING: 0
142137
displayName: Run integration tests (Remote)
143138
timeoutInMinutes: 20
144139
@@ -169,16 +164,10 @@ steps:
169164

170165
- script: yarn smoketest-no-compile --web --tracing --headless --electronArgs="--disable-dev-shm-usage"
171166
timeoutInMinutes: 20
172-
env:
173-
# TODO(deepak1556): Remove this once we update to Node.js >= 20.11.x
174-
UV_USE_IO_URING: 0
175167
displayName: Run smoke tests (Browser, Chromium)
176168

177169
- script: yarn smoketest-no-compile --remote --tracing
178170
timeoutInMinutes: 20
179-
env:
180-
# TODO(deepak1556): Remove this once we update to Node.js >= 20.11.x
181-
UV_USE_IO_URING: 0
182171
displayName: Run smoke tests (Remote)
183172

184173
- ${{ if ne(parameters.VSCODE_QUALITY, 'oss') }}:
@@ -189,8 +178,6 @@ steps:
189178
- script: yarn smoketest-no-compile --web --tracing --headless --electronArgs="--disable-dev-shm-usage"
190179
env:
191180
VSCODE_REMOTE_SERVER_PATH: $(agent.builddirectory)/vscode-server-linux-$(VSCODE_ARCH)-web
192-
# TODO(deepak1556): Remove this once we update to Node.js >= 20.11.x
193-
UV_USE_IO_URING: 0
194181
timeoutInMinutes: 20
195182
displayName: Run smoke tests (Browser, Chromium)
196183

@@ -201,9 +188,6 @@ steps:
201188
VSCODE_REMOTE_SERVER_PATH="$(agent.builddirectory)/vscode-server-linux-$(VSCODE_ARCH)" \
202189
yarn smoketest-no-compile --tracing --remote --build "$APP_PATH"
203190
timeoutInMinutes: 20
204-
env:
205-
# TODO(deepak1556): Remove this once we update to Node.js >= 20.11.x
206-
UV_USE_IO_URING: 0
207191
displayName: Run smoke tests (Remote)
208192
209193
- script: |

build/checksums/nodejs.txt

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
31d2d46ae8d8a3982f54e2ff1e60c2e4a8e80bf78a3e8b46dcaac95ac5d7ce6a node-v20.9.0-darwin-arm64.tar.gz
2-
fc5b73f2a78c17bbe926cdb1447d652f9f094c79582f1be6471b4b38a2e1ccc8 node-v20.9.0-darwin-x64.tar.gz
3-
d2a7dbeeb274bfd16b579d2cafb92f673010df36c83a5b55de3916aad6806a6a node-v20.9.0-linux-arm64.tar.gz
4-
a28a0de05177106d241ef426b3e006022bc7d242224adace7565868bd9ee6c06 node-v20.9.0-linux-armv7l.tar.gz
5-
f0919f092fbf74544438907fa083c21e76b2d7a4bc287f0607ada1553ef16f60 node-v20.9.0-linux-x64.tar.gz
6-
54e165b89e75158993910053db5b0e652c1826521e624126de5ca6de9ff7b06d win-arm64/node.exe
7-
538140015da83597ea7e7ef5e108ebac8a2dc4784b2a4134222b6c27c39f90ad win-x64/node.exe
1+
e0065c61f340e85106a99c4b54746c5cee09d59b08c5712f67f99e92aa44995d node-v20.11.1-darwin-arm64.tar.gz
2+
c52e7fb0709dbe63a4cbe08ac8af3479188692937a7bd8e776e0eedfa33bb848 node-v20.11.1-darwin-x64.tar.gz
3+
e34ab2fc2726b4abd896bcbff0250e9b2da737cbd9d24267518a802ed0606f3b node-v20.11.1-linux-arm64.tar.gz
4+
e42791f76ece283c7a4b97fbf716da72c5128c54a9779f10f03ae74a4bcfb8f6 node-v20.11.1-linux-armv7l.tar.gz
5+
bf3a779bef19452da90fb88358ec2c57e0d2f882839b20dc6afc297b6aafc0d7 node-v20.11.1-linux-x64.tar.gz
6+
a5a9d30a8f7d56e00ccb27c1a7d24c8d0bc96a2689ebba8eb7527698793496f1 win-arm64/node.exe
7+
bc585910690318aaebe3c57669cb83ca9d1e5791efd63195e238f54686e6c2ec win-x64/node.exe

cgmanifest.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -516,11 +516,11 @@
516516
"git": {
517517
"name": "nodejs",
518518
"repositoryUrl": "https://github.com/nodejs/node",
519-
"commitHash": "22f383dcd529d6bf790856db614a35fea78e825f"
519+
"commitHash": "9b1bf44ea9e7785e38c93b7d22d32dbca262df6c"
520520
}
521521
},
522522
"isOnlyProductionDependency": true,
523-
"version": "20.9.0"
523+
"version": "20.11.1"
524524
},
525525
{
526526
"component": {

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "code-oss-dev",
33
"version": "1.90.0",
4-
"distro": "0f8d3c619e9a416854972b1f496b1eedc727ab18",
4+
"distro": "0263315aff0fc2c40701c5b26cfc53a6f76bf058",
55
"author": {
66
"name": "Microsoft Corporation"
77
},

remote/.yarnrc

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
disturl "https://nodejs.org/dist"
2-
target "20.9.0"
3-
ms_build_id "274207"
2+
target "20.11.1"
3+
ms_build_id "275039"
44
runtime "node"
55
build_from_source "true"

resources/server/bin/code-server-linux.sh

-4
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,4 @@ esac
99

1010
ROOT="$(dirname "$(dirname "$(readlink -f "$0")")")"
1111

12-
# workaround for https://github.com/microsoft/vscode/issues/212678
13-
# Remove this once we update to Node.js >= 20.11.x
14-
export UV_USE_IO_URING=0
15-
1612
"$ROOT/node" ${INSPECT:-} "$ROOT/out/server-main.js" "$@"

0 commit comments

Comments
 (0)