Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 91b99e1

Browse files
authored
Debt - dispose child instantiation service (#213471)
1 parent d8c3723 commit 91b99e1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/vs/workbench/contrib/scm/browser/menus.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ export class SCMRepositoryMenus implements ISCMRepositoryMenus, IDisposable {
199199
]);
200200

201201
const serviceCollection = new ServiceCollection([IContextKeyService, this.contextKeyService]);
202-
instantiationService = instantiationService.createChild(serviceCollection);
202+
instantiationService = instantiationService.createChild(serviceCollection, this.disposables);
203203
this.titleMenu = instantiationService.createInstance(SCMTitleMenu);
204204
this.disposables.add(this.titleMenu);
205205

src/vs/workbench/contrib/scm/browser/scmViewPane.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2464,7 +2464,7 @@ class SCMInputWidget {
24642464
};
24652465

24662466
const services = new ServiceCollection([IContextKeyService, this.contextKeyService]);
2467-
const instantiationService2 = instantiationService.createChild(services);
2467+
const instantiationService2 = instantiationService.createChild(services, this.disposables);
24682468
this.inputEditor = instantiationService2.createInstance(CodeEditorWidget, this.editorContainer, editorConstructionOptions, codeEditorWidgetOptions);
24692469
this.disposables.add(this.inputEditor);
24702470

0 commit comments

Comments
 (0)