Merge pull request #617 from codestoryai/features/generate-quick-list-for-errors

[sidecar] generate quick list for errors

Author: theskcd

extensions/codestory/src/extension.ts

@@ -2,7 +2,7 @@
  *  Copyright (c) Microsoft Corporation. All rights reserved.
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
-import { commands, ExtensionContext, interactive, window, workspace, languages, modelSelection, env, csevents } from 'vscode';
+import { commands, ExtensionContext, interactive, window, workspace, languages, modelSelection, env, csevents, Uri, Position } from 'vscode';
 import * as os from 'os';
 import * as http from 'http';
 
@@ -302,4 +302,47 @@ export async function activate(context: ExtensionContext) {
 			);
 		}
 	});
+
+
+	// TODO(skcd): I promise to clean this up better, I am trying to see if things still
+	// work if I wait here and check the diagnostics and if its working
+	// await new Promise(resolve => setTimeout(resolve, 20000));
+	// // over here we will execute the code action provider
+	// try {
+	// 	const textDocumentUri = Uri.file('/Users/skcd/scratch/sidecar/sidecar/src/agentic/symbol/helpers.rs');
+	// 	// opens the text document as required
+	// 	await workspace.openTextDocument(textDocumentUri);
+	// 	const range = new vscode.Range(new Position(3, 24), new Position(3, 25));
+	// 	const codeActions: vscode.CodeAction[] = await commands.executeCommand(
+	// 		'vscode.executeCodeActionProvider',
+	// 		textDocumentUri,
+	// 		range,
+	// 	);
+	// 	console.log('code actions worked');
+	// 	// lets see what happens over here
+	// 	console.log(codeActions);
+	// 	const firstCodeActionCommand = codeActions[1].command;
+	// 	const firstCodeArguments = codeActions[1].command?.arguments;
+	// 	try {
+	// 		if (firstCodeActionCommand !== undefined && firstCodeArguments !== undefined) {
+	// 			// console.log(firstCodeAction.command);
+	// 			// console.log(firstCodeAction.arguments);
+	// 			console.log(firstCodeArguments[0]);
+	// 			const firstArgument = firstCodeArguments[0][0].arguments;
+	// 			console.log(firstArgument);
+	// 			const result = await commands.executeCommand('rust-analyzer.resolveCodeAction', firstArgument);
+	// 			// const result = await commands.executeCommand(firstCodeActionCommand.command, ...firstCodeArguments);
+	// 			console.log('sub results from result');
+	// 			console.log(result);
+	// 		} else {
+	// 			console.log('missing command');
+	// 		}
+	// 	} catch (exception) {
+	// 		console.log(exception);
+	// 	}
+	// 	// await commands.executeCommand(codeActions[0].command, ...codeActions[1].arguments);
+	// } catch (exception) {
+	// 	console.log('code action execution error');
+	// 	console.error(exception);
+	// }
 }

extensions/codestory/src/server/quickFix.ts

@@ -0,0 +1,26 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as vscode from 'vscode';
+import { SidecarQuickFixRequest, SidecarQuickFixResponse } from './types';
+
+// TODO(skcd): This is not complete yet, we have to invoke the request
+// multiple times and then invoke the request and save the changes
+export async function quickFixList(request: SidecarQuickFixRequest): Promise<SidecarQuickFixResponse> {
+	const textDocumentUri = vscode.Uri.file(request.fs_file_path);
+	await vscode.workspace.openTextDocument(textDocumentUri);
+	const codeActions: vscode.CodeAction[] = await vscode.commands.executeCommand(
+		'vscode.executeCodeActionProvider',
+		textDocumentUri,
+		request.range,
+	);
+	// Over here try to get all the code actions which we need to execute
+	const titles = codeActions.map((codeAction) => {
+		return codeAction.title;
+	});
+	return {
+		options: titles,
+	};
+}

extensions/codestory/src/server/requestHandler.ts

@@ -3,13 +3,14 @@
  *  Licensed under the MIT License. See License.txt in the project root for license information.
  *--------------------------------------------------------------------------------------------*/
 import * as http from 'http';
-import { SidecarDiagnosticsRequest, SidecarGoToDefinitionRequest, SidecarGoToImplementationRequest, SidecarOpenFileToolRequest } from './types';
+import { SidecarDiagnosticsRequest, SidecarGoToDefinitionRequest, SidecarGoToImplementationRequest, SidecarOpenFileToolRequest, SidecarQuickFixRequest } from './types';
 import { Position, Range } from 'vscode';
 import { getDiagnosticsFromEditor } from './diagnostics';
 import { openFileEditor } from './openFile';
 import { goToDefinition } from './goToDefinition';
 import { SIDECAR_CLIENT } from '../extension';
 import { goToImplementation } from './goToImplementation';
+import { quickFixList } from './quickFix';
 
 // Helper function to read the request body
 function readRequestBody(req: http.IncomingMessage): Promise<string> {
@@ -72,6 +73,13 @@ export async function handleRequest(req: http.IncomingMessage, res: http.ServerR
 			const response = await goToImplementation(request);
 			res.writeHead(200, { 'Content-Type': 'application/json' });
 			res.end(JSON.stringify(response));
+		} else if (req.method === 'POST' && req.url === '/invoke_quick_fix') {
+			console.log('quick-fix');
+			const body = await readRequestBody(req);
+			const request: SidecarQuickFixRequest = JSON.parse(body);
+			const response = await quickFixList(request);
+			res.writeHead(200, { 'Content-Type': 'application/json' });
+			res.end(JSON.stringify(response));
 		} else {
 			console.log('HC request');
 			res.writeHead(200, { 'Content-Type': 'application/json' });

extensions/codestory/src/server/types.ts

@@ -67,3 +67,22 @@ export type SidecarGoToImplementationRequest = {
 export type SidecarGoToImplementationResponse = {
 	implementation_locations: FileAndRange[];
 };
+
+export type SidecarQuickFixRequest = {
+	fs_file_path: string;
+	range: {
+		startPosition: {
+			line: number;
+			character: number;
+		};
+		endPosition: {
+			line: number;
+			character: number;
+		};
+	};
+};
+
+// Keeping it simple for now
+export type SidecarQuickFixResponse = {
+	options: string[];
+};