-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-JVM targets broken with latest CMP 1.8.0-alpha01 #2771
Comments
Is this present in the latest snapshot? I wonder if it's related to 3.0.4 being built with Kotlin 2.0.21 instead of 2.1.0. |
Unfortunately it still happens with the snapshot. I also ended up trying with CMP 1.8.0+dev1992 and still no dice. I added
Which points to
There might be a method call in there that is broken on wasmJs. I think I can narrow it down, although not sure when I'll get to it. |
Actually, this is really bizarre. If I copy in a minimal working version of the demo app into the coil project, and point it to But if I point to I have a commit here with what I'm using to test. Linking to the dependency line that can be uncommented to test: main...TheKeeperOfPie:coil:main#diff-1c254051ac7f6b44bc168eec7bb31439bdc0593a0581463451988a906ec3af87R28 |
Actually this would make sense if something in 1.8.0-alpha01 broke binary compatibility or an experimental API or something. Since including the project locally would compile it against 1.8.0-alpha01. So likely this is a CMP issue. I'll come back to this once CMP ships another alpha or Coil updates to 1.8.0. |
Looks like this is due to binary incompatibility introduced in Compose 1.8.0 that only affects non-JVM platforms. I believe this is the ticket to watch for the fix. This comment indicates it should be fixed by In the meantime to unblock users from using the CMP 1.8.0 alphas I'm going to update Coil's snapshots to compile with allprojects {
repositories {
maven("https://oss.sonatype.org/content/repositories/snapshots")
}
} and update your Coil version to implementation("io.coil-kt.coil3:coil-compose:3.1.0-SNAPSHOT") |
The CMP 1.8.0-alpha02 version was reverted in 009abba#diff-697f70cdd88ba88fe77eebda60c7e143f6ad1286bca75017421e93ad84fb87dfL8, although the commit message says "Give up on Compose multiplatform test", so maybe this was intended. Just wanted to mention it in case anyone else is using the snapshot. |
@TheKeeperOfPie Sorry that was a mistake - |
This breaking change was reverted in AOSP, and included to 1.8.0-alpha03 |
Sounds good, I'm going to revert Coil's |
Describe the bug
On the latest CMP 1.8.0-alpha01, Coil in a
wasmJs
target is broken. The error is nebulous and I'm not really sure what's broken. It's highly likely this is just the alpha being an incomplete implementation, but wanted to file in case it actually is a Coil issue.1.7.3
(with no error and a red box displayed)
1.8.0-alpha01
To Reproduce
Using the demo from https://kotlinlang.org/docs/wasm-get-started.html, change the CMP version to
1.8.0-alpha01
, addimplementation("io.coil-kt.coil3:coil-compose:3.0.4")
, and add this toApp.kt
:Version
Coil: 3.0.4
Chrome: Version 133.0.6938.0 (Official Build) canary (64-bit)
The text was updated successfully, but these errors were encountered: