You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now co-busboy ignores files/fields with names like 'getOwnProperty'.
That's just wrong. There's no legal reason to ditch fields with valid names.
In theory, such names never happen. But if you think about a specific service for programmers, such names are perfectly normal. I had a problem with that thing and made PR to fix it.
PR #23 removes this technical restriction and fixes this behavior. Guess, the tests should be fixed too.
The text was updated successfully, but these errors were encountered:
iliakan
changed the title
PR #23 test fails due to bug in busboy
PR #23 test fails due to bug in co-busboy
Jun 17, 2015
Actually, if we support the newer nodejs only, I'd suggest using a Map.
In Object you can't achieve the 100% same behavior without tricks, because __proto__ is always special (ignored if assigned a primitive, I hope that's not an issue here).
Object.create(null) breaks every app that uses methods on the native Object.prototype. The only way to get around this is to restore proto after the fact, and then you're back where you started. This is a very unusual case. 99.9% of the time, the current behavior is what you would want. I haven't looked closely at Map yet, but maybe that's a better fit. Would probably still break a lot of apps though.
Right now co-busboy ignores files/fields with names like 'getOwnProperty'.
That's just wrong. There's no legal reason to ditch fields with valid names.
In theory, such names never happen. But if you think about a specific service for programmers, such names are perfectly normal. I had a problem with that thing and made PR to fix it.
PR #23 removes this technical restriction and fixes this behavior. Guess, the tests should be fixed too.
The text was updated successfully, but these errors were encountered: