Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #23 test fails due to bug in co-busboy #24

Open
iliakan opened this issue Jun 17, 2015 · 3 comments
Open

PR #23 test fails due to bug in co-busboy #24

iliakan opened this issue Jun 17, 2015 · 3 comments

Comments

@iliakan
Copy link

iliakan commented Jun 17, 2015

Right now co-busboy ignores files/fields with names like 'getOwnProperty'.
That's just wrong. There's no legal reason to ditch fields with valid names.

In theory, such names never happen. But if you think about a specific service for programmers, such names are perfectly normal. I had a problem with that thing and made PR to fix it.

PR #23 removes this technical restriction and fixes this behavior. Guess, the tests should be fixed too.

@iliakan iliakan changed the title PR #23 test fails due to bug in busboy PR #23 test fails due to bug in co-busboy Jun 17, 2015
@haoxins
Copy link
Member

haoxins commented Jun 17, 2015

I'm +1 for this, cc @fengmk2

@iliakan
Copy link
Author

iliakan commented Jun 17, 2015

Actually, if we support the newer nodejs only, I'd suggest using a Map.

In Object you can't achieve the 100% same behavior without tricks, because __proto__ is always special (ignored if assigned a primitive, I hope that's not an issue here).

@eivindfjeldstad
Copy link
Member

Object.create(null) breaks every app that uses methods on the native Object.prototype. The only way to get around this is to restore proto after the fact, and then you're back where you started. This is a very unusual case. 99.9% of the time, the current behavior is what you would want. I haven't looked closely at Map yet, but maybe that's a better fit. Would probably still break a lot of apps though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants