Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Install.completion flag is never used #232

Open
VPetukhov opened this issue Dec 12, 2022 · 3 comments
Open

[BUG] Install.completion flag is never used #232

VPetukhov opened this issue Dec 12, 2022 · 3 comments
Labels
bug Something isn't working need test this issue needs a proper test

Comments

@VPetukhov
Copy link
Contributor

Describe the bug

Parameter completion of the Install config is never used, so it's impossible to disable completion installation.

If I understand correctly, it's just a matter of adding !options.install.completion && return to the beginning of install_completion.

Version of the package:
v1.0.1
@VPetukhov VPetukhov added the bug Something isn't working label Dec 12, 2022
@Roger-luo
Copy link
Collaborator

Yes, that should do the job, and the build module indeed needs some love... I must admit that I wasn't very serious enough to rewrite this module last time.

@Roger-luo
Copy link
Collaborator

fixed in 5af139a

@Roger-luo Roger-luo added the need test this issue needs a proper test label Dec 15, 2022
@Roger-luo
Copy link
Collaborator

reopen since this behaviour is not tested

@Roger-luo Roger-luo reopened this Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working need test this issue needs a proper test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VPetukhov @Roger-luo