Skip to content
This repository has been archived by the owner on Oct 4, 2023. It is now read-only.

New booking fails on 5.27 #191

Open
clarkac1 opened this issue Jul 27, 2020 · 10 comments
Open

New booking fails on 5.27 #191

clarkac1 opened this issue Jul 27, 2020 · 10 comments

Comments

@clarkac1
Copy link

Selecting a new booking results in the attached screen so user cannot make a booking. CiviBooking version is 1.5.3 and Civi is at 5.27.3. This screen was working with 5.24.
screenshot_20200727_095523

@rubofvil
Copy link

Having same issue in 5.21.3

Seems that backbone is deprecated https://docs.civicrm.org/dev/en/latest/framework/backbone/

There is a plan of maintenance for the extension?

image

@clarkac1
Copy link
Author

It seems there is no maintenance on this extension, and I'm having discussions about a possible 'Make it Happen' campaign to get this working. Will keep you updated - you can email me at [email protected]

@rubofvil
Copy link

Thx @clarkac1 for the feedback.

I'm trying to add the missing dependencies in javascript.
If in the file booking.php you add next code seems that this part works (civicrm/booking/add?reset=1).

/**
 * Undocumented function
 *
 * @param [type] $formName
 * @param [type] $form
 * @return void
 */
function booking_civicrm_buildForm($formName, &$form) {
  CRM_Core_Resources::singleton()
  ->addScriptFile('civicrm', 'js/crm.backbone.js', 29990, 'html-header', FALSE);
}

@HeneryH
Copy link

HeneryH commented Nov 15, 2020

Bump, not a strong php coder but can help where possible. There are plenty of other booking/reservation tools out there but my need is to tie booking/reserving of club resources to payment and discounts. Each member gets x bookings for free (100% discount) then they have to pay.

@SarahFG
Copy link

SarahFG commented Mar 30, 2021

Hello, do you know if there was any movement with the 'make it happen' we have clients with issues who use Civibooking after security upgrade.

Thanks
Sarah

@akosgarai
Copy link

Hello. I have just opened a PR that contains fixes for this broken extension. But my problem is that i have never used this extension before, so that i have never seen it working. Could someone please help me testing my patch?

@diskbuster
Copy link

@akosgarai I just installed your extension, but still have the same issues unter Drupal 9 and CiviCRM 5.41.0
It is not possible to add a resource - get a empty Error 500 page.

@akosgarai
Copy link

Thank you @atk87a for testing it. Currently i'm not able to test it with D9 + CRM 5.41.0.
For me the add resource page loads well after the initial configuration. I'm testing it on D8 + CRM 5.37.1.
I have done the following steps to be able to create the resource.

  • Install the extension. (from administer menu)
  • Run database upgrades. (from administer)
  • At this time the Booking > New Booking loads well, but as the resources are not configured, the resource list is empty.
  • First i create the resource configuration set on the Administer > CiviBooking > Resource Configuration Set form. Set title to Example configuration set and save it. Then the options form: Label: Option 1, Price 10, Max size: 3, Unit: People, Enabled: true and save it.
  • Next create resource on the Administer > CiviBooking > Manage Resources form. Add resource. Resource type: Room, Label: Room One, Resource configuration set: Example configuration set Enabled: true, then save it.
  • Now the Booking > New Booking loads well, and the created resource appears in the list.

Maybe there are some logs about the 500 error that you experienced. Could you please check it? I believe it could be in the logfile inside the ConfigAndLog directory or in your server error log. (In case of apache it is /var/log/apache2/error.log)

@diskbuster
Copy link

I can't add a resource set or a resource. After setting php to 7.3 I get the following fatal error:
Access level to CRM_Admin_Form_ResourceConfigSet::$_id must be public (as in class CRM_Admin_Form) in /web/sites/default/files/civicrm/ext/uk.co.compucorp.civicrm.booking/CRM/Admin/Form/ResourceConfigSet.php on line 40

Drupal log stays empty and I should have the maximal access level as user 1.

@akosgarai
Copy link

It is strange. Are you sure that this patch is applied #194 @atk87a ? That id has been deleted in the patch: https://github.com/compucorp/civibooking/pull/194/files#diff-e403582107bc6ade4c4cfc502ba8f7c360cf823a845862473c74a8f0440684aeL41. The protected field is deleted, so that the parent class id field is used instead and the parent class is part of the crm core codebase.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants