Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Redo path specifications #98

Merged
merged 2 commits into from
Jun 11, 2021
Merged

[BREAKING] Redo path specifications #98

merged 2 commits into from
Jun 11, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 11, 2021

Closes #93.

@jwodder jwodder added the minor Increment the minor version when merged label Jun 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021 •
edited
Loading

Codecov Report

Merging #98 (215ec3f) into master (b4f1a5e) will decrease coverage by 32.41%.
The diff coverage is 22.03%.

❗ Current head 215ec3f differs from pull request most recent head 50d3ebe. Consider uploading reports for the commit 50d3ebe to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master      #98       +/-   ##
===========================================
- Coverage   72.95%   40.54%   -32.42%     
===========================================
  Files           9        8        -1     
  Lines         821      851       +30     
  Branches      121      127        +6     
===========================================
- Hits          599      345      -254     
- Misses        179      506      +327     
+ Partials       43        0       -43
Impacted Files Coverage Δ
src/tinuous/__main__.py 0.00% <0.00%> (-58.65%) ⬇️
src/tinuous/appveyor.py 32.14% <0.00%> (-48.11%) ⬇️
src/tinuous/base.py 61.90% <ø> (-25.40%) ⬇️
src/tinuous/github.py 30.50% <0.00%> (-26.65%) ⬇️
src/tinuous/travis.py 28.18% <0.00%> (-41.92%) ⬇️
src/tinuous/config.py 74.73% <68.42%> (-16.41%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f1a5e...50d3ebe. Read the comment docs.

@jwodder jwodder changed the title Redo path specifications [BREAKING] Redo path specifications Jun 11, 2021
yarikoptic
yarikoptic reviewed Jun 11, 2021
View reviewed changes
README.rst Outdated
current working directory) in which the job's logs will be saved.
See "`Path Templates`_" for more information.
``paths``
*(required)* A mapping giving `template strings <Path Templates_>`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't required any longer or is it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is required, but it can be empty.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would making it truly optional be doable? it is kinda odd to allow for it to be empty as indicator of "optional"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now optional.

@jwodder jwodder merged commit b17dc21 into master Jun 11, 2021
@jwodder jwodder deleted the gh-93 branch June 11, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow for "releases only" mode and may be RF specification for the paths?
3 participants
@jwodder @codecov-commenter @yarikoptic