Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An explicit {release} or {release_id} for {releases_path}? #94

Closed
yarikoptic opened this issue Jun 10, 2021 · 0 comments · Fixed by #97
Closed

An explicit {release} or {release_id} for {releases_path}? #94

yarikoptic opened this issue Jun 10, 2021 · 0 comments · Fixed by #97
Assignees

Comments

@yarikoptic
Copy link
Member

I happily ran (well -- almost, since that is what lead to all my reports on needing retries etc) tinuous for datalad/git-annex since: 2021-03-01T00:00:00Z and only at the end (since IIRC releases are fetched last) realized that releases_path: 'releases/' is not automagically places releases into subdirectories, so I ended up with

(tinuous-dev) datalad@smaug:/mnt/datasets/datalad/ci/git-annex$ ls releases/
git-annex_8.20210330-1.ndall+1_amd64.buildinfo   git-annex_8.20210330-1.ndall+1.tar.gz           git-annex_8.20210428-1.ndall+1_source.buildinfo  git-annex-installer_8.20210330_x64.exe
git-annex_8.20210330-1.ndall+1_amd64.changes     git-annex_8.20210330_x64.dmg                    git-annex_8.20210428-1.ndall+1_source.changes    git-annex-installer_8.20210428_x64.exe
git-annex_8.20210330-1.ndall+1.dsc               git-annex_8.20210428-1.ndall+1_amd64.buildinfo  git-annex_8.20210428-1.ndall+1.tar.gz            git-annex-standalone_8.20210330-1.ndall+1_amd64.deb
git-annex_8.20210330-1.ndall+1_source.buildinfo  git-annex_8.20210428-1.ndall+1_amd64.changes    git-annex_8.20210428_x64.dmg                     git-annex-standalone_8.20210428-1.ndall+1_amd64.deb
git-annex_8.20210330-1.ndall+1_source.changes    git-annex_8.20210428-1.ndall+1.dsc              git-annex-build.log

which obviously would get "busy" fast. And ideally in our case we need to place each release into a subdirectory... only really carefully searching for "release" I think I found the way -- {type_id} ! I have tried and that works. But IMHO it is very confusing since we describe types to be only (``cron``, ``pr``, or ``push``) so releases is not part of the "build type". That is why I thought it would be better to

  • not abuse type_id for releases
  • make it `releases_path: '{path_prefix}/{release_id}/' in the sample config in the README.md .
jwodder added a commit that referenced this issue Jun 11, 2021
[BREAKING] Replace `{type_id}` for releases with `{release_tag}`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants