Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Replace {type_id} for releases with {release_tag} #97

Merged
merged 1 commit into from
Jun 11, 2021
Merged

[BREAKING] Replace {type_id} for releases with {release_tag} #97

merged 1 commit into from
Jun 11, 2021

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 11, 2021

Closes #94.

@jwodder jwodder added the minor Increment the minor version when merged label Jun 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021 •
edited
Loading

Codecov Report

Merging #97 (b808392) into master (b4f1a5e) will decrease coverage by 31.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #97       +/-   ##
===========================================
- Coverage   72.95%   41.00%   -31.96%     
===========================================
  Files           9        8        -1     
  Lines         821      817        -4     
  Branches      121      121               
===========================================
- Hits          599      335      -264     
- Misses        179      482      +303     
+ Partials       43        0       -43
Impacted Files Coverage Δ
src/tinuous/github.py 31.12% <ø> (-26.03%) ⬇️
src/tinuous/__main__.py 0.00% <0.00%> (-58.65%) ⬇️
src/tinuous/appveyor.py 33.33% <0.00%> (-46.92%) ⬇️
src/tinuous/travis.py 28.97% <0.00%> (-41.13%) ⬇️
src/tinuous/base.py 61.90% <0.00%> (-25.40%) ⬇️
src/tinuous/config.py 77.21% <0.00%> (-13.93%) ⬇️
src/tinuous/util.py 79.54% <0.00%> (-6.82%) ⬇️
src/tinuous/_version.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f1a5e...b808392. Read the comment docs.

@jwodder jwodder changed the title Replace {type_id} for releases with {release_tag} [BREAKING] Replace {type_id} for releases with {release_tag} Jun 11, 2021
yarikoptic
yarikoptic approved these changes Jun 11, 2021
View reviewed changes
Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks lgtm, thank you!

@jwodder jwodder merged commit 85daedb into master Jun 11, 2021
@jwodder jwodder deleted the gh-94 branch June 11, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yarikoptic yarikoptic yarikoptic approved these changes

Assignees
No one assigned
Labels
minor Increment the minor version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

An explicit {release} or {release_id} for {releases_path}?
3 participants
@jwodder @codecov-commenter @yarikoptic