Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple applicable rules for Minion #405

Closed
niklasdewally opened this issue Nov 1, 2024 · 2 comments
Closed

Fix multiple applicable rules for Minion #405

niklasdewally opened this issue Nov 1, 2024 · 2 comments
Assignees
Labels
area::minion Related to minion_rs, the minion C++ bindings, and the minion solver interface. kind::bug Something isn't working priority::next We need this next.

Comments

@niklasdewally
Copy link
Collaborator

niklasdewally commented Nov 1, 2024

Sometimes, there are multiple applicable rules in tests. In #401 , we add a check for this, which causes test failures.

We only should have one representation of the model at the moment (per solver, at-least), and I am writing my Minion rules with a set order of operations in mind. These failing rules likely either have a bad priority, or don't have strict enough preconditions.

@niklasdewally niklasdewally added area::minion Related to minion_rs, the minion C++ bindings, and the minion solver interface. kind::bug Something isn't working priority::next We need this next. labels Nov 1, 2024
@niklasdewally niklasdewally self-assigned this Nov 1, 2024
@niklasdewally niklasdewally changed the title Fix multiple possible rules for Minion Fix multiple applicable rules for Minion Nov 1, 2024
@ozgurakgun
Copy link
Contributor

ozgurakgun commented Nov 1, 2024 via email

@niklasdewally
Copy link
Collaborator Author

Closed by #411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area::minion Related to minion_rs, the minion C++ bindings, and the minion solver interface. kind::bug Something isn't working priority::next We need this next.
Projects
None yet
Development

No branches or pull requests

2 participants