Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Send X-Forwarded-Host when using wildcard mirror #1434

Closed
dmayle opened this issue Apr 11, 2020 · 1 comment
Closed

Send X-Forwarded-Host when using wildcard mirror #1434

dmayle opened this issue Apr 11, 2020 · 1 comment

Comments

@dmayle
Copy link

dmayle commented Apr 11, 2020

Now that CRI supports a wildcard header for mirrors, we can have a problem implementing a pull through cache because of the ambiguity of the requested host (two different images with the same name on different backing registries). It also requires configuring the pull through cache to check all possible registries, since it does not know where the original image should be sourced.

If CRI were to set the X-Forwarded-Host header on the request, we could use that to solve both problems.

@dmcgowan
Copy link
Member

See containerd/containerd#3734

This needs to be implemented in the containerd libraries and done in a consistent way. Closing this one as it is tracked already in containerd and OCI distribution spec.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants