-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pretty bad H264 performance after upgrading to iOS 15.4 #744
Comments
I don't think compilation of WebRTCLib will help here, and BTW, you don't need that plugin to use WebRTC using iOS 15.4. Try without the plugin (comment register global) to see if Native iOS WebRTC also have the same performance issue. |
Update: Without using the globals of cordova-iosrtc: H264 works just fine with "native" WebRTC of Webkit. Pros:
Cons:
The plugin had a good run, but I think most users of this plugin can now move on to the "native" WebRTC of Webkit Anyway: The libwebrtc bug remains for H264 performance. This also happens in non cordova based projects when using libwebrtc |
Thank you @derMani
I agree, since iOS 15+, you don't really need the plugin if you don't have to put speaker on or support old iOS versions. Still you will have to deal with know ios safari webrtc issues that the plugin handle to manage (auto play, speaker, background). |
In any case I will leave this issue open to.see if updating to latest libwebrtc fix thr issues. |
@derMani see webrtc-100 PR that update webrtc to v100 that pass the CI (include full build test https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/.github/workflows/main.yml#L59) |
I think this project may still be useful if the H264 encoding issue can be fixed. It would be nice to be able to provide higher quality encoding than is available in the safari webrtc support. |
Hey @hthetiot, I've tested PR #748 on iPhone 14 Pro (iOS 16.3.1) and it fixes the H264 performance and fps issues. |
Hi together, sorry für the late reply. I can confirm, that this works now without stuttering (also on iOS16) 👍 |
Yep, #748 works fine 👍 |
Thx this help a lot to validate build. |
Hey @hthetiot, I continued testing PR #748 with my application and I noticed that, while H264 works fine, some WebRTC API's do not work like with [email protected]. I then tested [email protected] and it's the same case: After initiating a call and sending audio + video from iPhone 14 Pro to chrome browser
are always returning empty arrays in PR #748 and [email protected], while with version [email protected] there are correct Is this a bug? |
@hthetiot we are using WebRTC library from Chrome v102 pretty long time without any significant issues. But I have to check if we are using |
@dl4mmers do you know if you use webrtc-adapter that may be the cause of the issue, I have seen thr shim F* iosrtc sham in the past ? |
@hthetiot I think I did PRs for all my changes to |
@RSATom OK I will build or may be move to the jisti one use by react-native-webrtc and made original maintainers of iosrtc. |
@hthetiot Yeah I'm using webrtc-adapter, but I've looked through the swift code of RTCPeerConnection (https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/master/src/PluginRTCPeerConnection.swift#L324) and saw the check |
I will set unified-plan by default in next release I think it is time. Will avoid wasting people time. |
Hey @hthetiot, any news on releasing 10.x with WebRTC M100 or M102? |
Description
Hi everyone.
after upgrading our phones to iOS 15.4, we are experiencing a pretty bad H264 performance.
Versions before iOS 15.4 with the same source code are not affected by this provlem
I can provide a simple peer 2 peer example if needed
Console output looks normal.
Versions affected
Steps to reproduce
Establish an iPhone to Chrome video connection via H264 and compare it with VP8.
A lot of jitter and bad FPS situations will occur, if you observe chrome://webrtc-internals
Both H264 profiles in the SDP with cordova iosrtc are affected
Expected results
Fluid video image, like in previous versions.
Maybe an upgrade of the webrtc lib could help?
Actual results
Stuttering video quality with H.264
The text was updated successfully, but these errors were encountered: