Add support for Azure NVMe Disks #3378
Conversation
Add support for certain VM types (e.g. Standard_M16bds_v3, Standard_L8s_v4) that present managed disks as NVMe devices instead of traditional SCSI disks. This breaks LUN-based detection in the Azure Disk CSI driver, causing volume mount failures. Include the Azure provided udev rules[1] in the 25azure-udev-rules overlay. [1]: https://github.com/Azure/azure-vm-utils/blob/6fb0ae1d047c0f06e19aab8f1e27e2cd588a6f9f/udev/80-azure-disk.rules
The `azure-vm-utils` package provides Azure disk udev rules that support NVMe backed Azure Managed Disks. A few newer VM types (e.g. Standard_M16bds_v3, Standard_L8s_v4) present managed disks as NVMe devices instead of traditional SCSI disks. The package is only available for F42, so conditionally add it for that release version, while the needed udev rules are added in overlay/25azure-udev-rules for <42
| @@ -14,4 +14,5 @@ depends() { | |||
| # called by dracut | |||
| install() { | |||
| inst_rules 68-azure-sriov-nm-unmanaged.rules | |||
| inst_rules 80-azure-disk.rules | |||
There was a problem hiding this comment.
is this needed in the >=42 case?
There was a problem hiding this comment.
No it's not. Let's just drop the overlay altogether and just include the package (see comments on 80-azure-disk.rules)
There was a problem hiding this comment.
given our proximity to F42 I think I'd be OK just not including this in <F42 as it makes things simpler.
I know we need to do this downstream for a period of time, but would prefer to just have the rules live in the overlay there and never live here.
alternatively, we could message the package maintainer to ask if they'd build the RPM for F41.
There was a problem hiding this comment.
It makes sense to me to just include this the package in >=42. I split out the overlay part into a separate commit in case we wanted to do that.
I agree that we can just keep the overlay downstream until it's no longer needed there.
alternatively, we could message the package maintainer to ask if they'd build the RPM for F41.
That'd be fine as well because it would be cleaner to just include the package unconditionally, but it doesn't seem like there's a immediate need for this functionality here so we could just do this in >=42.
There was a problem hiding this comment.
do you want to send an email to them? address should be able to be lifted from the git log in distgit for the RPM.
I wasn't able to reproduce the exact issue, but I think I can confirm this fixes it. The issue is related to the Azure Disk CSI Driver not being able to perform LUN-based disk discovery without these udev rules. see: kubernetes-sigs/azuredisk-csi-driver#2777 I was able to confirm that the udev rules properly map NVMe devices in |
IOW we have enough to write a simple test for this? |
Looks like it! 👍 |
Add udev rules to support certain VM types (e.g. Standard_M16bds_v3, Standard_M16bs_v3, Standard_L8s_v4) that present managed disks as NVMe devices instead of traditional SCSI disks. This breaks LUN-based detection in the Azure Disk CSI driver, causing volume mount failures.
Add the azure provided udev rules[1] as an overlay and add the
azure-vm-utilspackage to >=42.[1]: https://github.com/Azure/azure-vm-utils/blob/6fb0ae1d047c0f06e19aab8f1e27e2cd588a6f9f/udev/80-azure-disk.rules