-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate the bootimage bump process #1086
base: main
Are you sure you want to change the base?
Conversation
0bc5bcb
to
e2aee23
Compare
jobs/bootimagebump.Jenkinsfile
Outdated
} | ||
|
||
stage('Create Pull Request') { | ||
//if (shwrapCapture("git diff --exit-code") != 0){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using git diff --exit-code seem to throw an issue here.
13:55:10 + git diff --exit-code
13:55:10 warning: Not a git repository. Use --no-index to compare two paths outside a working tree
13:55:10 usage: git diff --no-index [<options>] <path> <path>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't in the installer
directory so it is failing there. You can try git -C installer diff --exit-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the git -C installer diff --exit-code
, it seems to print out the output of git diff and then just exit the code with a failure, not quite evident why it is exiting after that check.
Posting the PR opened with this job for reference - openshift/installer@1a3dd3e Jenkins job - https://jenkins-fedora-coreos-pipeline.apps.ocp.stg.fedoraproject.org/job/bootimagebump/127/console |
52f7830
to
eb97d3d
Compare
jobs/bootimagebump.Jenkinsfile
Outdated
} | ||
|
||
stage('Create Pull Request') { | ||
//if (shwrapCapture("git diff --exit-code") != 0){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't in the installer
directory so it is failing there. You can try git -C installer diff --exit-code
861d6b6
to
4362e26
Compare
96f8d67
to
98a6925
Compare
Can this job run the |
This job currently does not support that but it is something that can be worked on from here. At the moment , we would have to run the cloud-replicate job and the bootimagebump jenkins job separately. |
This bootimagebump job would automate a part of the bootimage bump process by running the plume-cosa script and creating a PR for the rhcos build that is currently done manually. JIRA: https://issues.redhat.com/browse/COS-2205
153b152
to
93f0e74
Compare
This bootimagebump job would automate a part of the bootimage bump process by running the plume-cosa script and creating a PR for the rhcos build that is currently done manually.
JIRA: https://issues.redhat.com/browse/COS-2205