Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the bootimage bump process #1086

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aaradhak
Copy link
Member

@aaradhak aaradhak commented Jan 31, 2025

This bootimagebump job would automate a part of the bootimage bump process by running the plume-cosa script and creating a PR for the rhcos build that is currently done manually.

JIRA: https://issues.redhat.com/browse/COS-2205

@aaradhak aaradhak force-pushed the bootimagebump branch 4 times, most recently from 0bc5bcb to e2aee23 Compare February 12, 2025 18:46
@aaradhak aaradhak marked this pull request as ready for review February 12, 2025 19:13
}

stage('Create Pull Request') {
//if (shwrapCapture("git diff --exit-code") != 0){
Copy link
Member Author

@aaradhak aaradhak Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using git diff --exit-code seem to throw an issue here.

13:55:10  + git diff --exit-code
13:55:10  warning: Not a git repository. Use --no-index to compare two paths outside a working tree
13:55:10  usage: git diff --no-index [<options>] <path> <path>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't in the installer directory so it is failing there. You can try git -C installer diff --exit-code

Copy link
Member Author

@aaradhak aaradhak Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the git -C installer diff --exit-code , it seems to print out the output of git diff and then just exit the code with a failure, not quite evident why it is exiting after that check.

@aaradhak
Copy link
Member Author

aaradhak commented Feb 12, 2025

Posting the PR opened with this job for reference - openshift/installer@1a3dd3e
(The indentation of the commit message needs to be addressed)

Jenkins job - https://jenkins-fedora-coreos-pipeline.apps.ocp.stg.fedoraproject.org/job/bootimagebump/127/console

}

stage('Create Pull Request') {
//if (shwrapCapture("git diff --exit-code") != 0){
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't in the installer directory so it is failing there. You can try git -C installer diff --exit-code

@aaradhak aaradhak force-pushed the bootimagebump branch 3 times, most recently from 861d6b6 to 4362e26 Compare February 12, 2025 23:26
@aaradhak aaradhak requested a review from mike-nguyen February 12, 2025 23:34
@aaradhak aaradhak force-pushed the bootimagebump branch 3 times, most recently from 96f8d67 to 98a6925 Compare February 13, 2025 02:42
@mike-nguyen
Copy link
Member

Can this job run the cloud-replicate job and create the boot image PR?

@aaradhak
Copy link
Member Author

Can this job run the cloud-replicate job and create the boot image PR?

This job currently does not support that but it is something that can be worked on from here. At the moment , we would have to run the cloud-replicate job and the bootimagebump jenkins job separately.

This bootimagebump job would automate a part of the bootimage bump
process by running the plume-cosa script and creating a PR for the
rhcos build that is currently done manually.

JIRA: https://issues.redhat.com/browse/COS-2205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants