Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs/build: lock buildfetch to avoid simultaneous jobs race condition #1098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

jobs/build: lock buildfetch to avoid simultaneous jobs race condition #1098

wants to merge 1 commit into from
+14 −13

Conversation

c4rt0
Copy link
Member

@c4rt0 c4rt0 commented Feb 25, 2025

fixes: #1079

jbtrystram
jbtrystram requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more explanation in the commit message as well ?

@c4rt0 c4rt0 force-pushed the PR/lock_buildfetch branch from f9f9cc1 to a59eea8 Compare February 26, 2025 11:13
@c4rt0
jobs/build: lock buildfetch to avoid simultaneous jobs race condition
8206118 
We had an issue recently where kola-aws and kola-gcp were killed in
the fetch metadata step because they started at the same time.
This fix locks the buildfetch stage which only takes a few seconds.

fixes: coreos#1079
@c4rt0 c4rt0 force-pushed the PR/lock_buildfetch branch from a59eea8 to 8206118 Compare February 26, 2025 11:19
@c4rt0 c4rt0 marked this pull request as ready for review February 26, 2025 11:19
@c4rt0 c4rt0 requested a review from jbtrystram February 26, 2025 11:19
@dustymabe
Copy link
Member

the buildfetch that needs adjusting are the ones that download artifacts. Openstack/Azure download the actual image and the aws/gcp ones download the ostree. So basically we need the lock on the cloud kola jobs. We think this problem is exacerbated by all of these jobs getting kicked off at the exact same time.

So let's add a global lock to just those jobs. maybe call it cloud-buildfetch or something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbtrystram jbtrystram Awaiting requested review from jbtrystram

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a startup delay to kola-aws and kola-gcp jobs
3 participants
@c4rt0 @dustymabe @jbtrystram