Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial-type feedback comments from Brian Sipos #214

Open
gselander opened this issue Jan 27, 2025 · 1 comment
Open

Editorial-type feedback comments from Brian Sipos #214

gselander opened this issue Jan 27, 2025 · 1 comment

Comments

@gselander
Copy link
Collaborator

gselander commented Jan 27, 2025

https://mailarchive.ietf.org/arch/msg/cose/xwaKaVD2SJ3-uV0eh7WWYX3fp1Y/

  1. It is currently difficult to extract a full CDDL document for this
    draft. Could one be extracted and added to the Github repo for reference? Or
    some procedure for how we can extract a full, valid CDDL definition from the
    markdown?
    I did some copy-paste work to get this and am running into tool errors, it
    seems like the 'time' rule is missing but maybe I'm extracting an
    incomplete set..?
    Also some reference CDDL like the 'oid' from RFC 9090 needs to be included
    somehow; manually in a Github file is fine, but having a complete and
    parseable CDDL document would be very valuable for users.

  2. The IANA sections which include what looks like a
    dictionary-list-within-table-cells makes reading and interpreting the tables
    difficult to me. Some IANA registries with many fields use a pure
    dictionary-list representation to avoid having a table with large numbers of
    columns.

  3. Also in IANA tables having multiple forms of the PKIX OIDs is
    convenient but somewhat confusing that they are all just in the text without
    specific labels or explanations. I can infer that they are 'name
    (dotted-decimal) hex-binary' but being more explicit in the form and
    explanation could be helpful (see no. 2 above about separating registry
    fields).

@gselander
Copy link
Collaborator Author

Questions for @BrianSipos (and others having an opinion) related to the points above:

@cabo made PR #215 and responded to the COSE mailing list:
https://mailarchive.ietf.org/arch/msg/cose/rEuV4sohR-0GZnuAj8becdXtwkU/
Does this solve the problem?

Does this comment refer to all sections 9.3-9.11?

Some IANA registries with many fields ...

Do you have an RFC reference, or example of a preferred representation?

What kind of explanations are you missing? Please give an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant