Calculate address balances using only successful transactions

Author: ohrite

priv/repo/migrations/20180216011950_create_balances_views.exs

@@ -10,9 +10,9 @@ defmodule Explorer.Repo.Migrations.CreateBalancesViews do
         COALESCE(MIN(transactions.inserted_at), NOW()) AS inserted_at,
         COALESCE(MAX(transactions.inserted_at), NOW()) AS updated_at
       FROM addresses
-      LEFT OUTER JOIN to_addresses ON to_addresses.address_id = addresses.id
-      LEFT OUTER JOIN transactions ON transactions.id = to_addresses.transaction_id
-      LEFT OUTER JOIN receipts ON receipts.transaction_id = transactions.id AND receipts.status = 1
+      INNER JOIN to_addresses ON to_addresses.address_id = addresses.id
+      INNER JOIN transactions ON transactions.id = to_addresses.transaction_id
+      INNER JOIN receipts ON receipts.transaction_id = transactions.id AND receipts.status = 1
       GROUP BY addresses.id
     ;
     """
@@ -25,9 +25,9 @@ defmodule Explorer.Repo.Migrations.CreateBalancesViews do
         COALESCE(MIN(transactions.inserted_at), NOW()) AS inserted_at,
         COALESCE(MAX(transactions.inserted_at), NOW()) AS updated_at
       FROM addresses
-      LEFT OUTER JOIN from_addresses ON from_addresses.address_id = addresses.id
-      LEFT OUTER JOIN transactions ON transactions.id = from_addresses.transaction_id
-      LEFT OUTER JOIN receipts ON receipts.transaction_id = transactions.id AND receipts.status = 1
+      INNER JOIN from_addresses ON from_addresses.address_id = addresses.id
+      INNER JOIN transactions ON transactions.id = from_addresses.transaction_id
+      INNER JOIN receipts ON receipts.transaction_id = transactions.id AND receipts.status = 1
       GROUP BY addresses.id
     ;
     """

test/explorer/credit_test.exs

@@ -8,17 +8,10 @@ defmodule Explorer.CreditTest do
       assert Repo.all(Credit) == []
     end
 
-    test "returns a credit when there is an address" do
-      address = insert(:address)
-      Credit.refresh
-      credit = Credit |> preload([:address]) |> Repo.one
-      assert credit.address == address
-    end
-
-    test "returns zero credits when an address has no transactions" do
+    test "returns nothing when an address has no transactions" do
       insert(:address)
       Credit.refresh
-      assert Repo.one(Credit).value == Decimal.new(0)
+      assert Repo.one(Credit) == nil
     end
 
     test "returns a credit when there is an address with a receipt" do
@@ -30,10 +23,10 @@ defmodule Explorer.CreditTest do
       insert(:to_address, transaction: transaction, address: receipient)
       Credit.refresh
       credits = Credit |> Repo.all
-      assert credits |> Enum.count == 2
+      assert credits |> Enum.count == 1
     end
 
-    test "returns no credit to the sender" do
+    test "returns no credits to the sender" do
       receipient = insert(:address)
       sender = insert(:address)
       transaction = insert(:transaction, value: 21)
@@ -43,7 +36,7 @@ defmodule Explorer.CreditTest do
       address_id = sender.id
       Credit.refresh
       credit = Credit |> where(address_id: ^address_id) |> Repo.one
-      assert credit.value == Decimal.new(0)
+      assert credit == nil
     end
 
     test "returns a credit to the receipient" do

test/explorer/debit_test.exs

@@ -8,17 +8,10 @@ defmodule Explorer.DebitTest do
       assert Repo.all(Debit) == []
     end
 
-    test "returns a debit when there is an address" do
-      address = insert(:address)
-      Debit.refresh
-      debit = Debit |> preload([:address]) |> Repo.one
-      assert debit.address == address
-    end
-
-    test "returns zero debits when an address has no transactions" do
+    test "returns nothing when an address has no transactions" do
       insert(:address)
       Debit.refresh
-      assert Repo.one(Debit).value == Decimal.new(0)
+      assert Repo.one(Debit) == nil
     end
 
     test "returns a debit when there is an address with a receipt" do
@@ -30,7 +23,7 @@ defmodule Explorer.DebitTest do
       insert(:to_address, transaction: transaction, address: receipient)
       Debit.refresh
       debits = Debit |> Repo.all
-      assert debits |> Enum.count == 2
+      assert debits |> Enum.count == 1
     end
 
     test "returns a debit against the sender" do
@@ -46,7 +39,7 @@ defmodule Explorer.DebitTest do
       assert debit.value == Decimal.new(21)
     end
 
-    test "returns no debit against the receipient" do
+    test "returns no debits against the receipient" do
       receipient = insert(:address)
       sender = insert(:address)
       transaction = insert(:transaction, value: 21)
@@ -56,7 +49,7 @@ defmodule Explorer.DebitTest do
       address_id = receipient.id
       Debit.refresh
       debit = Debit |> where(address_id: ^address_id) |> Repo.one
-      assert debit.value == Decimal.new(0)
+      assert debit == nil
     end
   end
 end

test/explorer/forms/address_form_test.exs

@@ -7,13 +7,19 @@ defmodule Explorer.AddressFormTest do
 
   describe "build/1" do
     test "returns a balance" do
-      address = insert(:address, %{hash: "bert"})
-      insert(:transaction, value: 5) |> with_addresses(%{to: "bert", from: "ernie"})
-      insert(:transaction, value: 5) |> with_addresses(%{to: "bert", from: "kermit"})
+      sender = insert(:address)
+      recipient = insert(:address)
+      transaction = insert(:transaction, value: 10)
+      block = insert(:block)
+      insert(:block_transaction, block: block, transaction: transaction)
+      insert(:receipt, transaction: transaction, status: 1)
+      insert(:from_address, address: sender, transaction: transaction)
+      insert(:to_address, address: recipient, transaction: transaction)
 
       Credit.refresh
       Debit.refresh
-      assert AddressForm.build(Repo.preload(address, [:debit, :credit])).balance == Decimal.new(10)
+
+      assert AddressForm.build(Repo.preload(recipient, [:debit, :credit])).balance == Decimal.new(10)
     end
 
     test "returns a zero balance when the address does not have balances" do

test/explorer/workers/refresh_balance_test.exs

@@ -13,6 +13,7 @@ defmodule Explorer.Workers.RefreshBalanceTest do
         address = insert(:address)
         transaction = insert(:transaction, value: 20)
         insert(:to_address, address: address, transaction: transaction)
+        insert(:receipt, transaction: transaction, status: 1)
         RefreshBalance.perform
         assert Repo.one(Credit).value == Decimal.new(20)
       end
@@ -23,6 +24,7 @@ defmodule Explorer.Workers.RefreshBalanceTest do
         address = insert(:address)
         transaction = insert(:transaction, value: 20)
         insert(:from_address, address: address, transaction: transaction)
+        insert(:receipt, transaction: transaction, status: 1)
         RefreshBalance.perform
         assert Repo.one(Debit).value == Decimal.new(20)
       end
@@ -34,6 +36,7 @@ defmodule Explorer.Workers.RefreshBalanceTest do
       address = insert(:address)
       transaction = insert(:transaction, value: 20)
       insert(:to_address, address: address, transaction: transaction)
+      insert(:receipt, transaction: transaction, status: 1)
       RefreshBalance.perform("credit")
       assert Repo.one(Credit).value == Decimal.new(20)
     end
@@ -42,6 +45,7 @@ defmodule Explorer.Workers.RefreshBalanceTest do
       address = insert(:address)
       transaction = insert(:transaction, value: 20)
       insert(:from_address, address: address, transaction: transaction)
+      insert(:receipt, transaction: transaction, status: 1)
       RefreshBalance.perform("debit")
       assert Repo.one(Debit).value == Decimal.new(20)
     end