You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Coveralls GitHub Action requires a secret token, that is only available for pull requests in two cases:
Pull request was open from the same repository
GitHub Action workflow was triggered by pull_request_target event.
The latter, however, appears to be completely ignored by this action. I do not receive a PR comment, and the UI is showing that the target commit is my main branch HEAD.
Apparently, Coveralls uses $GITHUB_SHA to identify the commit. Which in case of pull_request_target equals to the main commit, not the PR commit. I tried fixing that with the following snippet:
but the commit hash on the Coveralls UI remains the same, and the comparison fails.
Here's an example of a PR: perf-toolbox/tir#29
And whatever was generated for that event: https://coveralls.io/builds/67039590
Even though I delete a bunch of tests, the Coveralls shows that the PR introduced no changes. Only after I commit that PR, I can see my updated coverage info.
The text was updated successfully, but these errors were encountered:
Coveralls GitHub Action requires a secret token, that is only available for pull requests in two cases:
pull_request_target
event.The latter, however, appears to be completely ignored by this action. I do not receive a PR comment, and the UI is showing that the target commit is my main branch HEAD.
Apparently, Coveralls uses
$GITHUB_SHA
to identify the commit. Which in case ofpull_request_target
equals to the main commit, not the PR commit. I tried fixing that with the following snippet:but the commit hash on the Coveralls UI remains the same, and the comparison fails.
Here's an example of a PR: perf-toolbox/tir#29
And whatever was generated for that event: https://coveralls.io/builds/67039590
Even though I delete a bunch of tests, the Coveralls shows that the PR introduced no changes. Only after I commit that PR, I can see my updated coverage info.
The text was updated successfully, but these errors were encountered: