Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter to call #21

Open
matham opened this issue May 31, 2023 · 0 comments
Open

Parameter to call #21

matham opened this issue May 31, 2023 · 0 comments

Comments

@matham
Copy link
Contributor

matham commented May 31, 2023

Generally, a function should not return different types of things depending on a argument passed to it. Instead, it's generally preferable to split it into 2 functions. Matplotlib violates this a lot and returns different things based on the input and it's annoying af.

If we need __call__ to return the combinations, I'd suggest we only return that and have a different method e.g. get_data_frame that returns a data frame when called. Although I'm not sure we should use pandas so much in the codebase because there are downsides to making that a dependency of the framework.

Originally posted by @matham in #1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant