Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having a per file config dict #26

Open
matham opened this issue May 31, 2023 · 0 comments
Open

Having a per file config dict #26

matham opened this issue May 31, 2023 · 0 comments

Comments

@matham
Copy link
Contributor

matham commented May 31, 2023

There's something erking me here. Because you have a folder with logged files and a single config dict. The dict applies to all files in the folder? So for all the files we extract the same properties? Would we want to maybe have a per file config dict?

You're using plot_tensorboard only in generic pipeline rn so I understand that all files would be processed the same way. But, as a stand alone function, maybe it should instead accept a h5 filename, a list of attrs and settings and have the pipeline do the folder crawling etc. Partially it's also because HDFData accepts a buffer, so why not re-use it if we're reading multiple attrs from the same file. Or, why have it accept a buffer? If the same attr can be specified multiple times, then TensorboardWriter should be able to deal with that making it unique. If it can't, like it currently seems to be the case, the not just do it all in one HDFData?

But anyway that can all be left for later.

Originally posted by @matham in #1 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant