Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve array comparison during import #1238

Closed
boudewijn-zicht opened this issue Feb 13, 2023 · 3 comments
Closed

Improve array comparison during import #1238

boudewijn-zicht opened this issue Feb 13, 2023 · 3 comments
Labels

Comments

@boudewijn-zicht
Copy link
Contributor

Two more PR's that improve how values are compared to reduce the updates done during import

#1237
#1236

@kristiansp
Copy link
Contributor

kristiansp commented Feb 17, 2023

I also have a really old pull request that's kind of related, to sort arrays before comparing, as otherwise it will always update if the elements are in a different order. Could maybe be combined.

#735

@kristiansp
Copy link
Contributor

kristiansp commented Feb 17, 2023

Another unrelated and simple pull request regarding performance, with the hope that it will be seen – checking if an element is already disabled before disabling it, avoiding to uneccessarily save them again (I have the need to update elements that might be enabled later under certain circumstances, and can't see it could hurt not to disable something that is already disabled).

#736

@angrybrad
Copy link
Member

Resolved on develop branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants