Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save files are quite large #15

Open
bmeyers opened this issue Jan 22, 2025 · 0 comments
Open

Save files are quite large #15

bmeyers opened this issue Jan 22, 2025 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bmeyers
Copy link
Member

bmeyers commented Jan 22, 2025

The new save functionality added in PR #14 generates files that are ~25MB for 1 year of PV data, 11 quantiles, and 12 harmonics. This could be improved by not saving the basis dictionary itself, which can be regenerated quickly at load time. Proposed solution:

  • Deep copy the instantiated object
  • Delete basis dictionary attribute
  • Save the file to disk
  • Regenerate the basis dictionary from class kwargs at load time
@bmeyers bmeyers added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmeyers